Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#6923 closed enhancement (fixed)

Add support for uploading patches to trac with grunt task `grunt patch`

Reported by: netweb Owned by: netweb
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Cc:

Description

The upcoming 0.4.0 release of grunt-patch-wordpress will support uploading patches to Trac.

For example: grunt upload_patch:98765 will upload a diff/patch of the current directory to ticket #98765

The attached patch is just for the new Grunt task grunt upload_patch:xxxx where xxxx is the ticket number, before committing this both grunt-patch-wordpress version 0.4.0 needs to be released and a subsequent ticket created to first update BuddyPress to use grunt-patch-wordpress

Attachments (4)

6923-manually-uploaded.diff (347 bytes) - added by netweb 4 years ago.
6923.diff (63 bytes) - added by jorbin 3 years ago.
6923.2.diff (808 bytes) - added by netweb 3 years ago.
6923.3.diff (755 bytes) - added by DJPaul 3 years ago.

Download all attachments as: .zip

Change History (18)

#2 @netweb
4 years ago

The 6923-manually-uploaded.diff was manually uploaded which is sad, its working for bbPress and WordPress Trac.

I'm presuming this is an issue with the Trac plugin TracXMLRPC 1.1.2 or configuration of that plugin.

I'll add more information once I know more via aaronjorbin/grunt-patch-wordpress/pull/32

#3 @DJPaul
4 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Under Consideration to 2.6

#4 follow-up: @DJPaul
4 years ago

From Github

The TracXMLRPC package needs to be enabled, and the endpoint for patch uploads must be open to all users.

The TracXMLRPC package is enabled on this Trac and all its features seem to be enabled.

#5 in reply to: ↑ 4 @netweb
4 years ago

Replying to DJPaul:

From Github

The TracXMLRPC package needs to be enabled, and the endpoint for patch uploads must be open to all users.

The TracXMLRPC package is enabled on this Trac and all its features seem to be enabled.

Thanks, am just waiting for the new release of grunt-patch-wordpress to drop with this

#6 @DJPaul
4 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

#7 @DJPaul
4 years ago

  • Milestone changed from 2.6 to Future Release

Will move to appropriate release version when final patch is ready.

@jorbin
3 years ago

#8 follow-up: @jorbin
3 years ago

The permissions don't seem to be enabled for everyone (for example, I couldn't upload this patch), but 0.4.0 is now available. Also adds support for github urls.

#9 in reply to: ↑ 8 @netweb
3 years ago

Replying to jorbin:

The permissions don't seem to be enabled for everyone (for example, I couldn't upload this patch), but 0.4.0 is now available. Also adds support for github urls.

I thought it may have enabled for the "Gardeners" group here also like as it is for WordPress Trac, but I could also not upload a patch via grunt upload_patch:6923, so it mustn't be, we'll have to get that enabled.

Committed to WordPress core via https://core.trac.wordpress.org/changeset/37612

@netweb
3 years ago

#10 @netweb
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to netweb
  • Status changed from new to accepted

Adding a copy of the #core commit message:


Update grunt-patch-wordpress to 0.4.0

This update adds two main features for your WordPress development happiness.

1) GitHub URL support. You can now use grunt patch:https://github.com/aaronjorbin/develop.wordpress/pull/3 with any copy of WordPress on GitHub. No longer will you need to download the patch manually. Works for both core and develop mirrors on GitHub.

2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. grunt upload_patch:20000 will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug gardeners). You still need to manually add the has patch keyword.

Full changelog: https://github.com/aaronjorbin/grunt-patch-wordpress/compare/0.3.0...0.4.0

#11 @netweb
3 years ago

  • Keywords commit added

#12 @DJPaul
3 years ago

  • Component changed from Tools - Build Process to Build/Test Tools

@DJPaul
3 years ago

#13 @djpaul
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10936:

Update grunt-patch-wordpress to 0.4.0

This update adds two main features for your BuddyPress development happiness.

1) GitHub URL support. You can now use grunt patch:https://github.com/<org>/<repo>/pull/<id> with any copy of BuddyPress on GitHub. No longer will you need to download the patch manually.

2) Upload patches directly from the command line. No longer will you need to create a patch and manually upload it to trac. grunt upload_patch:20000 will upload a patch to the appropriate ticket after a user enters a WordPress.org username and password. This is limited to users with the appropriate XML-RPC privileges in trac (right now, that is just bug gardeners). You still need to manually add the has patch keyword.

Props netweb, jorbin, ericlewis, michaelbeil.

Fixes #6923

#14 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.7

I've added the XML-RPC permission to bug gardeners group.

Note: See TracTickets for help on using tickets.