Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6920 closed defect (bug) (fixed)

SCRIPT_DEBUG=false breaks asset enqueue path with WordPress release build + BuddyPress dev build

Reported by: DJPaul Owned by: djpaul
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

If you have a WordPress release build (that is, not the dev SVN with its src folder) with a BuddyPress dev build (with its src folder), and set SCRIPT_DEBUG=false, BuddyPress will try to load the minified versions of its CSS and JS assets. As these aren't present, they 404.

Attachments (1)

last-minute.patch (12.8 KB) - added by DJPaul 5 years ago.

Download all attachments as: .zip

Change History (4)

@DJPaul
5 years ago

#1 @netweb
5 years ago

+1 Works for me...

Tested permutations and combinations of SCRIPT_DEBUG with true and false with only BuddyPress /src folder

Then ran npm install to get a BuddyPress /build folder and tested again, all looks good

#2 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.5

going to sneak this in

#3 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10613:

Fix script/style enqueue path when using BP dev. repo. with release build of WP, and SCRIPT_DEBUG=false.

If you have a WordPress release build (that is, not the dev SVN with its src folder) with a BuddyPress dev build (with its src folder), and set SCRIPT_DEBUG=false, BuddyPress will try to load the minified versions of its CSS and JS assets. As these minified assets only exist in our release builds, this causes 404 errors in this particular set of circumstances.

Fixes #6920

Note: See TracTickets for help on using tickets.