Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#6918 closed enhancement (fixed)

Email: Prefix menu names with 'BuddyPress'

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.5 Priority: normal
Severity: trivial Version:
Component: Administration Keywords: has-patch ui-feedback
Cc:

Description (last modified by r-a-y)

In cases where other email plugins might have a similar admin menu name of "Emails", I'm proposing that we alter our email admin menu labels to add "BuddyPress".

Attached patch does the following:

  • Changes the menu name from "Emails" to "BP Emails" (We could use "BuddyPress Emails" here, but I thought it might be too long.)
  • Changes the header title from "Emails" to "BuddyPress Emails"
  • Changes the customizer heading from "Emails" to "BuddyPress Emails"
  • Changes the "Appearance > Emails" submenu name to "Appearance > BuddyPress Emails"
  • Adds a "BP Emails > Customize" submenu item so admins are aware that it is possible to use the WP customizer to alter the CSS of BP emails. This might be redundant as the "Appearance > BuddyPress Emails" submenu already exists, but I had a hard time finding it :)
  • Changes "Add a New Email" label to "Add a New BuddyPress Email"
  • Changes "Edit Email" label to "Edit BuddyPress Email"

I understand it is late to start making string changes, but I thought this was important enough to address for v2.5.

Let me know what everyone thinks.

Attachments (1)

6918.01.patch (3.3 KB) - added by r-a-y 4 years ago.

Download all attachments as: .zip

Change History (10)

@r-a-y
4 years ago

#1 @r-a-y
4 years ago

  • Description modified (diff)

#2 @DJPaul
4 years ago

We shouldn't use the acronym of our project for labelling the user interface.

There are also locale-specific concerns: certain languages are way longer than English (hello, German!) and will never fit in as concisely as our American English defaults are, and also -- this might be a UK-specific thing -- but we share "BP" with certain other organisations who might not be as warmly-received as BuddyPress is, and I think we'd annoy people. In fact, at the UK's BuddyCamp last year, we did not use the letters "BP" on anything for that precise reason (we'd have been thrown in the sea, at least!!).

In cases where other email plugins might have a similar admin menu name of "Emails"

What about plugins that add admin menus called "Activity" or "Groups"? This is a rabbit hole. At least all the BP wp-admin nav menu items are grouped together.

Looking at the patch:

  • I strongly disagree with prefixing menu names or the add/edit text with BP or BuddyPress. I think it's unnecessary unless there is evidence to back this up (user testing the email interface after 2.5 ships for 2.6 improvements might be an interesting idea) .
  • I agree to add Emails > Customize menu. I hadn't done that because I thought people knew the Customizer lives under the Appearance menu but (as per recent Slack chat) as a couple of you hadn't discovered that, that means lots of other people won't either. Great feedback!
  • I don't feel strongly about the Customizer panel label. In a perfect world, no-one sees it, I'm not sure what the benefit is, but we can make the change if you think it is better.
  • Likewise, if you want to change the page title text on edit.php?post_type=bp-email, because that's where people probably will click first to explore the interface. I begin to worry a little about the inconsistencies but we can always adjust in the future based on feedback or testing.

#3 @r-a-y
4 years ago

There are also locale-specific concerns: certain languages are way longer than English (hello, German!) and will never fit in as concisely as our American English defaults are, and also -- this might be a UK-specific thing -- but we share "BP" with certain other organisations

Good point. Might be better to use the full project name then?

What about plugins that add admin menus called "Activity" or "Groups"? This is a rabbit hole. At least all the BP wp-admin nav menu items are grouped together.

Yeah, I was thinking about this myself regarding "Activity" and "Groups".

I think with "Emails" though there is more of a chance of a conflict and general confusion.

eg. Did my favorite email plugin (WP blog email subscription, contact form) just add an "Emails" menu? Why are there two "Emails" menus?

Here are a few examples of plugins using "Emails" or "Email" from wp.org:

https://ps.w.org/email/assets/screenshot-3.png

https://ps.w.org/email-client/assets/banner-772x250.png

https://ps.w.org/email-cop/assets/screenshot-1.png

#6827 might help as well to some extent.

I guess it is probably better not to change the menu name for consistency with the existing "Activity" and "Groups" menu names.


I agree to add Emails > Customize menu.

.

I don't feel strongly about the Customizer panel label. In a perfect world, no-one sees it, I'm not sure what the benefit is, but we can make the change if you think it is better.

.

Likewise, if you want to change the page title text on edit.php?post_type=bp-email, because that's where people probably will click first to explore the interface. I begin to worry a little about the inconsistencies but we can always adjust in the future based on feedback or testing.

I would be happy enough with these changes for v2.5.

Would be great to hear what others think as well.

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


4 years ago

#5 @r-a-y
4 years ago

In 10608:

Emails: Change header label for custom post type and customizer panel.

To be less ambiguous, we're changing the header label from "Emails" to
"BuddyPress Emails" on the main CPT admin page and in the customizer
panel.

See #6918.

#6 @r-a-y
4 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10610:

Emails: Change 'Excerpt' metabox to custom 'Plain text email content' metabox.

The 'Excerpt' metabox doesn't describe what we are using it for with our
BP email custom post type.

Unfortunately, to alter the default 'Excerpt' metabox, we need to
completely remove it and re-add the metabox to use our custom strings.

Props DJPaul.

Fixes #6918.

#7 @r-a-y
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ugh... r10610 references the wrong ticket! :(

Last edited 4 years ago by r-a-y (previous) (diff)

#8 @djpaul
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 10612:

Emails: add Emails > Customise menu item.

Feedback from regular BuddyPress testers and developers has suggested
the Appearance > Emails item (which takes you to the Customizer) is
not obvious to find.

Adding a Customizer item to the top-level Emails menu should increase
discoverability of the email appearance features.

Fixes #6918, props r-a-y

#9 @r-a-y
4 years ago

In 10615:

Emails: Change menu name in Network Admin area back to "Emails".

Inadvertently missed this one!

Props offereins.

See #6918.

Note: See TracTickets for help on using tickets.