Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#6917 closed defect (bug) (fixed)

Missing Non MS 2.5 deprecated filters for emails

Reported by: imath's profile imath Owned by: djpaul's profile djpaul
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

In 2.4 : the activation email is using 2 different functions with 2 different sets of filters.

In the 2.5 deprecated file, only the multisite filters are taking in account, meaning a plugin using a non MS filter could fail.

Attachments (1)

6917.patch​ (2.9 KB) - added by imath 9 years ago.

Download all attachments as: .zip

Change History (4)

@imath
9 years ago

#1 @DJPaul
9 years ago

It looks like I de-duplicated these functions but forget to accommodate the different filters for backwards compatibility. Good spot, and thank you for finding this. :)

#2 @djpaul
9 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10598:

Emails: reinstate missing filters for backwards compatibility.

The user registration and site registration functions (multisite and non-multisite paths) were consolidated as part of the email implementation in 2.5, but the different filter names were overlooked.
This change will restore compatibility for those old actions.

Fixes #6917

Props imath

#3 @DJPaul
8 years ago

  • Component changed from API to Core
Note: See TracTickets for help on using tickets.