Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6909 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (bp-blogs/bp-blogs-template.php)

Reported by: ramiy Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description

Old string:

  • <a href="%1$s">%2$s</a> is your new site. <a href="%3$s">Login</a> as "%4$s" using your existing password.

New strings:

  • %s is your new site.
  • <a href="%1$s">Login</a> as "%2$s" using your existing password.

The attached patch splits the original string into two shorter and easy to translate strings.

Also, replacing <a href="%1$s">%2$s</a> with %s.

Attachments (1)

6909.patch (938 bytes) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (7)

@ramiy
5 years ago

#1 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.5

#2 @DJPaul
5 years ago

  • Milestone changed from 2.5 to Under Consideration

I don't like this patch because it splits a paragraph into multiple phrases. I expect there may be languages where people want to re-order the sentences, or continue to have just one.

#3 @ramiy
5 years ago

@DJPaul

This patch is splitting the original string into two strings. The first string is an informative text where you inform the user about the new site. The second string is a call-to-action to login to the site.

#4 @boonebgorges
5 years ago

  • Milestone changed from Under Consideration to 2.6

Splitting seems acceptable in this case, though not much is gained from the split.

#5 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10682:

Improve the way blog signup confirmation strings are built.

  • Remove markup from the strings, where possible.
  • Use core functions to generate URLs, rather than manually concatenating.
  • Pass $blog_id to bp_blogs_confirm_blog_signup().

Props ramiy, boonebgorges.
Fixes #6909.

#6 @DJPaul
4 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.