Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 6 weeks ago

Last modified 6 weeks ago

#6890 closed enhancement (fixed)

Remove usage of deprecated bp_activity_delete_by_item_id() from various functions.

Reported by: tw2113's profile tw2113 Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version: 1.2
Component: Activity Keywords: good-first-bug has-patch
Cc:

Description (last modified by tw2113)

Should be able to transform current arguments into matching version for bp_activity_delete()

Found in:

bp_activity_post_type_unpublish()
bp_activity_post_type_remove_comment()
bp_blogs_delete_activity()
friends_delete_activity()
bp_groups_delete_group_delete_all_activity()
xprofile_delete_activity()

Attachments (1)

6890.diff​ (3.2 KB) - added by umesh.nevase 9 years ago.
I've replaced deprecated bp_activity_delete_by_item_id with bp_activity_delete. I've tested on my side, needs more testing.

Download all attachments as: .zip

Change History (12)

#1 @tw2113
10 years ago

  • Description modified (diff)
  • Summary changed from Remove usage of deprecated bp_activity_delete_by_item_id() from friends_delete_activity() to Remove usage of deprecated bp_activity_delete_by_item_id() from various functions.

#2 @DJPaul
10 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone changed from Awaiting Review to 2.6

This ticket was mentioned in ​Slack in #buddypress by dcavins. ​View the logs.
10 years ago

#4 @DJPaul
10 years ago

  • Milestone changed from 2.6 to Future Release

#5 @DJPaul
10 years ago

  • Component changed from API to Core

#6 @slaFFik
9 years ago

  • Milestone changed from Future Release to 2.8

@umesh.nevase
9 years ago

I've replaced deprecated bp_activity_delete_by_item_id with bp_activity_delete. I've tested on my side, needs more testing.

#7 @DJPaul
9 years ago

  • Milestone changed from 2.8 to Future Release

This ticket was mentioned in ​PR #431 on ​buddypress/buddypress by ​renatonascalves.
6 weeks ago #8

  • Keywords has-patch added; needs-patch removed

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/6890

#9 @espellcaste
6 weeks ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Contributions to 15.0.0

#10 @espellcaste
6 weeks ago

  • Owner set to espellcaste
  • Resolution set to fixed
  • Status changed from new to closed

In 14187:

Activity: officially deprecate the following functions: bp_activity_delete_by_item_id, bp_activity_delete_by_content, bp_activity_delete_by_activity_id, and bp_activity_delete_for_user_by_component.

bp_activity_delete should be used instead and all instances were updated to the use it.

Initially at [5109].

Closes ​https://github.com/buddypress/buddypress/pull/431
Fixes #6890

#11 @espellcaste
6 weeks ago

  • Component changed from Core to Activity
  • Keywords has-patch added; needs-patch removed
  • Version set to 1.2
Note: See TracTickets for help on using tickets.