Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 10 months ago

Last modified 10 months ago

#6890 closed enhancement (fixed)

Remove usage of deprecated bp_activity_delete_by_item_id() from various functions.

Reported by: tw2113 Owned by: espellcaste
Priority: normal Milestone: 15.0.0
Component: Activity Version: 1.2
Severity: normal Keywords: good-first-bug has-patch
Cc:

Description (last modified by tw2113)

Should be able to transform current arguments into matching version for bp_activity_delete()

Found in:

bp_activity_post_type_unpublish()
bp_activity_post_type_remove_comment()
bp_blogs_delete_activity()
friends_delete_activity()
bp_groups_delete_group_delete_all_activity()
xprofile_delete_activity()

Attachments (1)

6890.diff​ (3.2 KB ) - added by umesh.nevase 10 years ago.
I've replaced deprecated bp_activity_delete_by_item_id with bp_activity_delete. I've tested on my side, needs more testing.

Download all attachments as: .zip

Change History (12)

#1 @tw2113
11 years ago

  • Description modified (diff)
  • Summary Remove usage of deprecated bp_activity_delete_by_item_id() from friends_delete_activity() → Remove usage of deprecated bp_activity_delete_by_item_id() from various functions.

#2 @DJPaul
11 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone Awaiting Review → 2.6

This ticket was mentioned in ​Slack in #buddypress by dcavins. ​View the logs.
11 years ago

#4 @DJPaul
10 years ago

  • Milestone 2.6 → Future Release

#5 @DJPaul
10 years ago

  • Component API → Core

#6 @slaFFik
10 years ago

  • Milestone Future Release → 2.8

@umesh.nevase
10 years ago

I've replaced deprecated bp_activity_delete_by_item_id with bp_activity_delete. I've tested on my side, needs more testing.

#7 @DJPaul
10 years ago

  • Milestone 2.8 → Future Release

This ticket was mentioned in ​PR #431 on ​buddypress/buddypress by ​renatonascalves.
10 months ago #8

  • Keywords has-patch added; needs-patch removed

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/6890

#9 @espellcaste
10 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone Awaiting Contributions → 15.0.0

#10 @espellcaste
10 months ago

  • Owner set to espellcaste
  • Resolution → fixed
  • Status new → closed

In 14187:

Activity: officially deprecate the following functions: bp_activity_delete_by_item_id, bp_activity_delete_by_content, bp_activity_delete_by_activity_id, and bp_activity_delete_for_user_by_component.

bp_activity_delete should be used instead and all instances were updated to the use it.

Initially at [5109].

Closes ​https://github.com/buddypress/buddypress/pull/431
Fixes #6890

#11 @espellcaste
10 months ago

  • Component Core → Activity
  • Keywords has-patch added; needs-patch removed
  • Version → 1.2
Note: See TracTickets for help on using tickets.