Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6869 closed defect (bug) (fixed)

No more screen notifications for Activity mentions

Reported by: imath Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Toolbar & Notifications Keywords: needs-patch
Cc:

Description

There are a bunch of tests that are failing about activity mentions :

BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_single_activity_permalink
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_single_activity_permalink_logged_out
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_single_activity_permalink_wrong_user
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_mentions
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_mentions_logged_out
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_mentions_wrong_user
BP_Tests_Activity_Notifications::test_bp_activity_at_mention_delete_notification
BP_Tests_Activity_Notifications::test_bp_activity_remove_screen_notifications_on_new_mentions_cleared

I haven't found what commit caused this yet, but if the tests were failing i wonder how we missed it ??

And if the tests are failing that's because there's no more screen notifications created when a user mentions another one. So there's a real bug here.

Change History (7)

#1 @imath
4 years ago

@djpaul

1) i don’t find the 'bp_sent_email' do_action() or do_action_ref_array() in the code. It looks like it’s not fired or is it a dynamic action ?
2) I think there’s something wrong here, screen notifications should happen whatever is the user preference for emails. If you look at the 2.4 branch the do_action( 'bp_activity_sent_mention_email' ) was always fired. See https://buddypress.trac.wordpress.org/browser/branches/2.4/src/bp-activity/bp-activity-notifications.php#L147
3) Core functions shouldn't hook to deprecated actions imho.

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


4 years ago

#3 @DJPaul
4 years ago

Good spot with bp_sent_email. I can't figure out how to link to it on Github, but looking at my other Git repo, I can see that used to exist but I obviously have renamed it after.

The new actions are bp_send_email_failure or bp_send_email_success. Changing this obviously will allow the backpat code to load, but itself doesn't pass the test failures. I'm looking at the rest of your feedback.

#4 @djpaul
4 years ago

In 10494:

Emails: fix name of action used to implement backwards compatibility with old BuddyPress.

Props imath

See #6592 and #6869.

#5 @DJPaul
4 years ago

3) Core functions shouldn't hook to deprecated actions imho.

Obviously, not intentional, just overlooked. I expect remaining testing before release will find any other bits missed.

#6 @DJPaul
4 years ago

bp_activity_sent_mention_email should be handled by the backwards compatibility code that's now going to be used. :)
Take a look at bp_core_deprecated_email_actions

#7 @DJPaul
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This was fixed; commit will be logged against #6592 somewhere.

Note: See TracTickets for help on using tickets.