Remove remove_node 'edit' in bp-core-adminbar.php

[hnla]

In bp-core-adminbar.php we address empty edit links for post/pages being created by removing the 'node' L: 43.

if ( is_buddypress() ) {
 $wp_admin_bar->remove_node( 'edit' );
}

This carries the comment that it ought to be removed when a WP ticket/patch is committed that checks for empty edit link before rendering. This ticket and patch has been committed and closed 17 months ago:
​https://core.trac.wordpress.org/ticket/29538

Time to remove?

[DJPaul]

Let's wait until our minimum WP version is 4.1. Should be sometime later this year, at current rate. I'll tag this 4.1!

[tw2113]

We now support only 4.1+ for WordPress.

Any reason not to close this one now @DJPaul @hnla ?

[hnla]

Yes needs to be actioned then.

[tw2113]

I suspect it'll be fine, but the attached diff is ready for quick review @hnla

[hnla]

@tw2113 Patched but oddly this removal doesn't have desired effect, I see the edit link back in on the main WP adminbar, not sure why at this stage.

[tw2113]

In 11560:

Re-adds "Edit" node after WordPress core ticket had been patched to check for empty edit links. Fixes #6831.