Skip to:
Content

Opened 3 years ago

Closed 21 months ago

#6831 closed enhancement (fixed)

Remove remove_node 'edit' in bp-core-adminbar.php

Reported by: hnla Owned by: tw2113
Milestone: 2.9 Priority: low
Severity: minor Version:
Component: Core Keywords: needs-patch WP4.1
Cc:

Description

In bp-core-adminbar.php we address empty edit links for post/pages being created by removing the 'node' L: 43.

if ( is_buddypress() ) {
 $wp_admin_bar->remove_node( 'edit' );
}

This carries the comment that it ought to be removed when a WP ticket/patch is committed that checks for empty edit link before rendering. This ticket and patch has been committed and closed 17 months ago:
https://core.trac.wordpress.org/ticket/29538

Time to remove?

Attachments (1)

6831-remove-edit-link.diff (586 bytes) - added by tw2113 22 months ago.

Download all attachments as: .zip

Change History (11)

#1 @DJPaul
3 years ago

  • Keywords 4.1 added

Let's wait until our minimum WP version is 4.1. Should be sometime later this year, at current rate. I'll tag this 4.1!

#2 @DJPaul
3 years ago

  • Keywords WP4.1 added; 4.1 removed
  • Milestone changed from Awaiting Review to Future Release

#3 @DJPaul
3 years ago

  • Type changed from task to enhancement

#4 @tw2113
3 years ago

We now support only 4.1+ for WordPress.

Any reason not to close this one now @DJPaul @hnla ?

#5 @hnla
3 years ago

Yes needs to be actioned then.

#6 @tw2113
23 months ago

  • Owner set to tw2113
  • Status changed from new to assigned

#7 @hnla
23 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Future Release to 2.9

#8 @tw2113
22 months ago

I suspect it'll be fine, but the attached diff is ready for quick review @hnla

#9 @hnla
22 months ago

@tw2113 Patched but oddly this removal doesn't have desired effect, I see the edit link back in on the main WP adminbar, not sure why at this stage.

Ignore above, the issue was an empty link not no link, so lets commit!

Last edited 22 months ago by hnla (previous) (diff)

#10 @tw2113
21 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11560:

Re-adds "Edit" node after WordPress core ticket had been patched to check for empty edit links. Fixes #6831.

Note: See TracTickets for help on using tickets.