Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6826 closed enhancement (fixed)

Add BP styles for the Welcome Screen

Reported by: mercime Owned by: mercime
Milestone: 2.5 Priority: normal
Severity: major Version:
Component: Core Keywords: has-patch commit
Cc:

Description

  1. We've been updating and playing catch-up to fix wrecked BP welcome screens (aka About Page) layouts whenever a new version of WP has changed/removed styles at least least twice, to wit: https://buddypress.trac.wordpress.org/ticket/5561 and https://buddypress.trac.wordpress.org/ticket/6582.
  1. Then recently, karmatosed brought to our attention that the nice layout we had for BP 2.4.0 as shown here https://buddypress.trac.wordpress.org/attachment/ticket/6651/2-4-welcome-screen-final.png now needs vertical spacing between feature images and headings in WP 4.4+.
  1. In addition, BP 2.4.0 supports WP 3.8.0 through WP 4.4+. The layout of our About Page is wrecked in WP 3.8+/3.9+. See screenshot https://www.dropbox.com/s/a1364kitjzggayy/WP-39-BP-25.png?dl=0

We cannot rely on WP's ever-changing styles for this page as evidenced above. WP core has done what they want with the styles for what they need to show in the project’s About page, and rightly so. This ticket will create/adopt/adapt styles for BP's About Page to avoid any more breakage in new WP versions as well as in the older WP versions that we still support.

Attachments (1)

6826.patch (20.1 KB) - added by mercime 4 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
4 years ago

FYI, BP 2.5 will require WP 3.9. Also, my proposed email change currently has a dependency on WP 4.0 though we may be able to work around that.

Last edited 4 years ago by DJPaul (previous) (diff)

#2 @hnla
4 years ago

So in a nutshell we have been relying on inheriting many styles for our screen layout from WP styles, WP changes those styles drastically and our layouts collapse causing unnecessary time and effort redoing.

If WP re-factors their screen so drastically according to what they need for any given version and that is never likely to suit our requirements then yes we should describe explicit styles to manage our screen layout.

#3 @mercime
4 years ago

Thank you both for your feedback :)

@DJPaul Yes, I checked on both WP 3.8 and 3.9 as I was working on the styles for #6803.

@hnla Exactly!

Will be working on the patch this weekend.

#4 @DJPaul
4 years ago

  • Milestone changed from 2.5 to 2.6

@mercime
4 years ago

#5 @mercime
4 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5

We need this patch for the 2.5.0 Welcome screen #6886 so that the layout would show well in WP 3.9+. This would also ensure that our layout will be future-proof against changes made to WP core's about.css for 4.5.0.

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


4 years ago

#7 @DJPaul
4 years ago

  • Keywords commit added

#8 @mercime
4 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10617:

Update stylesheets for the Welcome Screen.

Provide style support for our Welcome Screen in the older versions
of WordPress which we still support and ensure that our layout doesn't
break when WP core's about.css is changed.

Fixes #6826.

Note: See TracTickets for help on using tickets.