Skip to:
Content

BuddyPress.org

Opened 4 years ago

Last modified 4 years ago

#6808 new defect (bug)

Group Invites Option persists even though disabled friending removes invites tab

Reported by: modemlooper Owned by:
Milestone: Awaiting Contributions Priority: high
Severity: normal Version: 2.4.0
Component: Friends Keywords: needs-patch
Cc: dcavins

Description

To reproduce:

deactivate friending component
visit group settings (option to choose who can invite is there)
invites tab is disabled

So you can choose option but no way to access the send invites page. I think we should use a define like define( 'BP_MESSAGES_AUTOCOMPLETE_ALL', true );

To allow the send invites to stay and use all members

Change History (6)

#1 @modemlooper
4 years ago

but the options shouldn't be there if they do nothing

#2 @boonebgorges
4 years ago

  • Keywords needs-patch added; dev-feedback removed

I agree that the current reliance on the Friends component is pretty crummy. But:

a) the Send Invites interface is pretty heavily dependent on autocomplete, and autocomplete performance breaks down quickly when working with lots of members. That's why BP_MESSAGES_AUTOCOMPLETE_ALL is turned off by default. (My plugin Invite Anyone enables autocomplete for all members.

b) Turning on Send Invites and allowing autocomplete for all users is a potential vector for spam. It may be unwise to have it on by default.

If we can find a way to mitigate these issues, or at least explain our way out of them :), I would be glad to change the default behavior to something more sensible.

In the meantime, an off-by-default constant or filter like the one you've suggested would be fine.

#3 @modemlooper
4 years ago

After playing with this, I think its best to just hide the options if friends is inactive. The UI would need to be reworked for an auto complete. currently its a list of checkboxes. No way to us that UI for all members.

#4 @boonebgorges
4 years ago

  • Milestone changed from Awaiting Review to Future Release

The UI would need to be reworked for an auto complete.

Oh right, I think I wrote the autocomplete as part of my Invite Anyone plugin.

We *should* do a rework of this UI at some point, so let's keep the ticket open. cc @dcavins

#5 @imath
4 years ago

FWIW here's an example of what could be achieved :) https://vimeo.com/145308971

#6 @dcavins
4 years ago

  • Cc dcavins added

I was just going to say that @imath worked on that in his template pack. :)

Note: See TracTickets for help on using tickets.