#6803 closed enhancement (fixed)
Improve mobile view of the BuddyPress Components panel
| Reported by: | mercime | Owned by: | mercime |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.5 |
| Component: | Core | Version: | |
| Severity: | normal | Keywords: | has-patch has-screenshots commit |
| Cc: |
Description
Will be attaching an image which shows the current mobile view of the Components panel and what we're going for in the first pass to improve the layout. To do: add some list table classes, remove some hard-coded styles, and adjust style as needed per check with WP 3.8.
Attachments (4)
Change History (10)
#1
@
11 years ago
- Keywords good-first-bug needs-patch added
- Milestone Awaiting Review → Future Release
#2
@
11 years ago
- Keywords has-patch has-screenshots added; good-first-bug needs-patch removed
- Milestone Future Release → 2.5
- Owner set to
- Status new → assigned
First pass at improving the mobile view of the Components screen. The attached patch:
- Uses WP_List_Table responsive goodness
- Removes inline styles
- Removes unused table markup
- Moves the
labeltags into the same table cells of the associatedinputfields - Adds checked/disabled checkbox input fields
- Adds dashicons back to the Core and Member components
- Adds style support to improve the new look
Also attached are the before and after screenshots of the desktop and mobile views.
#3
@
11 years ago
- Keywords commit added
Looks fantastic! Patch is also great, there is one small improvement you could make here:
<label for="bp_components[<?php echo esc_attr( $name ); ?>]" class="screen-reader-text"
To
<label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class="screen-reader-text"
It's slightly easier to read if the entire property is being escaped, rather than just the dynamic part.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Absolutely. Nice spot.