Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#6803 closed enhancement (fixed)

Improve mobile view of the BuddyPress Components panel

Reported by: mercime Owned by: mercime
Priority: normal Milestone: 2.5
Component: Core Version:
Severity: normal Keywords: has-patch has-screenshots commit
Cc:

Description

Will be attaching an image which shows the current mobile view of the Components panel and what we're going for in the first pass to improve the layout. To do: add some list table classes, remove some hard-coded styles, and adjust style as needed per check with WP 3.8.

Attachments (4)

mobile-view-components.jpg (93.7 KB ) - added by mercime 11 years ago.
6803.patch (6.5 KB ) - added by mercime 11 years ago.
6803-new-component-desktop.png (53.8 KB ) - added by mercime 11 years ago.
6803-new-component-mobile.png (168.8 KB ) - added by mercime 11 years ago.

Download all attachments as: .zip

Change History (10)

#1 @DJPaul
11 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone Awaiting ReviewFuture Release

Absolutely. Nice spot.

@mercime
11 years ago

#2 @mercime
11 years ago

  • Keywords has-patch has-screenshots added; good-first-bug needs-patch removed
  • Milestone Future Release2.5
  • Owner set to mercime
  • Status newassigned

First pass at improving the mobile view of the Components screen. The attached patch:

  • Uses WP_List_Table responsive goodness
  • Removes inline styles
  • Removes unused table markup
  • Moves the label tags into the same table cells of the associated input fields
  • Adds checked/disabled checkbox input fields
  • Adds dashicons back to the Core and Member components
  • Adds style support to improve the new look

Also attached are the before and after screenshots of the desktop and mobile views.

#3 @DJPaul
11 years ago

  • Keywords commit added

Looks fantastic! Patch is also great, there is one small improvement you could make here:

<label for="bp_components[<?php echo esc_attr( $name ); ?>]" class="screen-reader-text"

To

<label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class="screen-reader-text"

It's slightly easier to read if the entire property is being escaped, rather than just the dynamic part.

#4 @mercime
11 years ago

Thank you @DJPaul :) Changed all instances per your advice. Will commit in a few minutes.

#5 @mercime
11 years ago

  • Resolutionfixed
  • Status assignedclosed

In 10465:

Improve mobile view of the Settings > Components panel.

  • Use WP_List_Table responsive goodness.
  • Move label tags into the same table cells of the associated input fields.
  • Remove inline styles.
  • Remove unused table markup.
  • Add checked/disabled checkbox input fields.
  • Add dashicons back to the Core and Member components.
  • Add style support to improve the new look.

Props @DJPaul.
Fixes #6803.

#6 @DJPaul
10 years ago

  • Component General - UX/UICore
Note: See TracTickets for help on using tickets.