#6803 closed enhancement (fixed)
Improve mobile view of the BuddyPress Components panel
Reported by: | mercime | Owned by: | mercime |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch has-screenshots commit |
Cc: |
Description
Will be attaching an image which shows the current mobile view of the Components panel and what we're going for in the first pass to improve the layout. To do: add some list table classes, remove some hard-coded styles, and adjust style as needed per check with WP 3.8.
Attachments (4)
Change History (10)
#1
@
9 years ago
- Keywords good-first-bug needs-patch added
- Milestone changed from Awaiting Review to Future Release
#2
@
9 years ago
- Keywords has-patch has-screenshots added; good-first-bug needs-patch removed
- Milestone changed from Future Release to 2.5
- Owner set to mercime
- Status changed from new to assigned
First pass at improving the mobile view of the Components screen. The attached patch:
- Uses WP_List_Table responsive goodness
- Removes inline styles
- Removes unused table markup
- Moves the
label
tags into the same table cells of the associatedinput
fields - Adds checked/disabled checkbox input fields
- Adds dashicons back to the Core and Member components
- Adds style support to improve the new look
Also attached are the before and after screenshots of the desktop and mobile views.
#3
@
9 years ago
- Keywords commit added
Looks fantastic! Patch is also great, there is one small improvement you could make here:
<label for="bp_components[<?php echo esc_attr( $name ); ?>]" class="screen-reader-text"
To
<label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class="screen-reader-text"
It's slightly easier to read if the entire property is being escaped, rather than just the dynamic part.
Absolutely. Nice spot.