#6799 closed enhancement (fixed)
Unify structure of item lists.
Reported by: | dcavins | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.4.0 |
Component: | Templates | Keywords: | |
Cc: | dcavins |
Description
Unordered lists with the class item-list
are used in the default template to represent object lists, usually members or group but also activity. The list items in these lists don't share a common structure, which makes styling them in a general way harder than it needs to be. There seems to be one common form, and then a variety of others:
The first has three containers within the li, an avatar container, a div.item
that contains details like the name, updates, description, and a div.action
. It is generally structured like so:
<li> <div class="item-avatar"></div> <div class="item"> <div class="item-title"></div> <div class="item-meta"></div> <div class="item-desc"></div> </div> <div class="action"> <div class="meta"></div> </div> </li>
and is used in these cases:
blogs/blogs-loop.php
groups/groups-loop.php
members/members-loop.php
members/single/friends/requests.php
Then there are the other cases. These generally don't contain the wrapper div.item
, but just have the details loose in the li
:
activity/entry.php
groups/create.php
groups/single/admin.php
<- this one's particularly troublesome, with an h5 wrapping a bunch of actions.groups/single/invites-loop.php
groups/single/members.php
groups/single/requests-loop.php
members/single/groups/invites.php
I don't think we should change the current legacy template--it would cause too much heartache. But in the next iteration, we could give themers a nice gift by minimizing the number of structures used in the templates.
This is part of the overall task I want to get under-way, in updating the core templates used as defaults.
Issues like this though do require that templates are re-thought, and as such means it's not something that can be performed on existing templates due to back pat concerns, not to mention that doing one thing must lead on to another. it's a big task and I'm reckoning it's run across two release periods, I've a ticket proposal from a while back and comments in slack just before xmas.