Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6780 closed defect (bug) (fixed)

Issue with friendship activity when friend has deleted his account

Reported by: dishantcdn123 Owned by: r-a-y
Milestone: 2.5 Priority: normal
Severity: major Version: 2.4.0
Component: Activity Keywords: good-first-bug has-patch
Cc: dishantagrawal@…

Description

I had a friend and in activity it shows “[MY NAME] and [FRIEND NAME] are now friends”. But when my friend has deleted his account, activity says “[MY NAME] and are now friends”.

When friend deleted his account, this activity should be deleted from DB as well as from activity list.

Attachments (1)

6780.01.patch (2.4 KB) - added by r-a-y 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @dishantcdn123
5 years ago

  • Cc dishantagrawal@… added
  • Milestone changed from 2.4.4 to BuddyPress.org
  • Type changed from task to defect (bug)

#2 @dishantcdn123
5 years ago

  • Milestone changed from BuddyPress.org to Future Release

#3 @boonebgorges
5 years ago

  • Keywords needs-patch needs-unit-tests good-first-bug added
  • Priority changed from highest to normal

Hi @dishantcdn123 - Thanks for the report, and welcome to BuddyPress Trac!

Looking through the code, it looks like you're right: when a user is deleted, her friendships are deleted, but not the activity item related to the friendship. Let's fix this.

#4 @dishantcdn123
5 years ago

  • Milestone changed from Future Release to 2.4.4

#5 @boonebgorges
5 years ago

  • Milestone changed from 2.4.4 to 2.5

@dishantcdn123 - Since this is not a 2.4 regression (it's always been this way, as far as I can see), we won't address it in 2.4.4. It'd be great to do it for 2.5, but we will need a patch.

#6 @dishantcdn123
5 years ago

I want to make a suggestion here that when user deletes his account, definitely you are deleting his activity posts. During this process where user is involved inactivity posts, that posts are not considered to delete; especially posts of activity type 'friendship-request'. So this can give you head start to solve this issue.

@r-a-y
5 years ago

#7 @r-a-y
5 years ago

  • Keywords has-patch added; needs-patch needs-unit-tests removed

01.patch should delete friendship activity items when a user is deleted.

Pending any issues, I will commit this.

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.


5 years ago

#9 @r-a-y
5 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10563:

Friends: Delete 'friendship_created' activity items when a user is deleted.

Fixes #6780.

Note: See TracTickets for help on using tickets.