#6778 closed enhancement (fixed)
BP oEmbed should switch auto discovery to `true`
Reported by: | r-a-y | Owned by: | imath |
---|---|---|---|
Milestone: | 2.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch commit |
Cc: |
Description
As imath noted in ticket:6772#comment:9, WordPress switched their oEmbed discover switch to true
in WordPress 4.4.0.
This allows WP to embed posts automatically into the WP TinyMCE editor without having to register themselves as an oEmbed provider.
We should follow suit.
Maybe we should change our custom prefixed filter to just use WP's 'embed_oembed_discover'
instead.
Attachments (2)
Change History (8)
#2
@
9 years ago
Thanks r-a-y
Just tested the patch, and it's now possible to embed WordPress posts into the activity stream.
I'm not sure about changing the filter. I guess there can be edge cases where Admins want to disable embeds in BuddyPress and not in WordPress and vice and versa :)
#3
@
9 years ago
I think we should only change this part if the WordPress installed version is 4.4+. See 6778.02.patch.
#4
@
9 years ago
- Keywords commit added
imath - I like your idea way better than mine! I would say commit it.
Happy with your patch but if you want a crazy idea: we could pass their filter's value to our filter.