Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6778 closed enhancement (fixed)

BP oEmbed should switch auto discovery to `true`

Reported by: r-a-y Owned by: imath
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description

As imath noted in ticket:6772#comment:9, WordPress switched their oEmbed discover switch to true in WordPress 4.4.0.

This allows WP to embed posts automatically into the WP TinyMCE editor without having to register themselves as an oEmbed provider.

We should follow suit.

Maybe we should change our custom prefixed filter to just use WP's 'embed_oembed_discover' instead.

Attachments (2)

6778.01.patch (958 bytes) - added by r-a-y 5 years ago.
6778.02.patch (1.3 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (8)

@r-a-y
5 years ago

#1 @DJPaul
5 years ago

Happy with your patch but if you want a crazy idea: we could pass their filter's value to our filter.

#2 @imath
5 years ago

Thanks r-a-y

Just tested the patch, and it's now possible to embed WordPress posts into the activity stream.

I'm not sure about changing the filter. I guess there can be edge cases where Admins want to disable embeds in BuddyPress and not in WordPress and vice and versa :)

#3 @imath
5 years ago

I think we should only change this part if the WordPress installed version is 4.4+. See 6778.02.patch.

@imath
5 years ago

#4 @r-a-y
5 years ago

  • Keywords commit added

imath - I like your idea way better than mine! I would say commit it.

Last edited 5 years ago by r-a-y (previous) (diff)

#5 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10548:

Allow oEmbed discovery when WordPress version is 4.4+

WordPress 4.4 introduced Post embeds, allowing oEmbed discovery by default. We are using the same behavior for configs using at least WordPress 4.4 so that Post urls can be converted to Post embeds into the activity stream.

Props r-a-y

Fixes #6778

#6 @DJPaul
4 years ago

  • Component changed from API to Core
Note: See TracTickets for help on using tickets.