Typo in bp_activity_set_post_type_tracking_args()

[danbrellis]

The function bp_activity_set_post_type_tracking_args adds the post labels in a foreach loop, and then unsets each $arg that was passed to it.

The function says

unset( $args[ $post_type ] );

but since there is no $post_type key in the $args array, I think it should actually be:

unset( $args[ $label_type ] );

Was just poking around in the code and noticed this so sorry if I'm off base here.

[dcavins]

Hi @danbrellis-

Thanks for your bug report! I'm not terribly familiar with this particular cul-de-sac of the BuddyPress code, but I agree with your conclusion--it looks like what's meant to happen here is those label arguments are unset so they aren't added to the $wp_post_types global.

Thanks again for taking the time to write up a report.

[imath]

@dcavins

Yes sorry for this typo error. This function is not used by BuddyPress internally but is there for plugins wishing to add BuddyPress Post type activities: ​https://codex.buddypress.org/plugindev/post-types-activities/#customizing-generic-activity-attributes

The goal was to only have the labels ( inside the array like 'bp_activity_admin_filter' ) in $wp_post_types[ $post_type ]->labels and not "repeated" inside $wp_post_types[ $post_type ]->bp_activity.

[imath]

6777.patch is fixing the typo, i've added a unit test.

[DJPaul]

Tested, looks good.

[imath]

In 10412:

Fix a typo in the bp_activity_set_post_type_tracking_args() function

Add a unit test to check activity tracking arguments are added the same way to the post type when setting them within register_post_type() or using the bp_activity_set_post_type_tracking_args()

Props danbrellis

Fixes #6777