Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6772, comment 40


Ignore:
Timestamp:
05/27/2016 05:08:37 AM (8 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6772, comment 40

    initial v1  
    88- Uses the SVG play icon from [http://ionicons.com Ionicons] (licensed under the MIT).  If we'd rather stick with WP's dashicons, we can do that, but the dashicons play icon is a little too pointy.  This is pretty much a cosmetic thing and isn't really pertinent.
    99- In order for links to work while using `<iframe sandbox>`, I had to add the `sandbox="allow-top-navigation"` attribute.  The other gotcha here is in order for links to be clickable, links must use `top.location.href`.  (See `bp_activity_embed_excerpt_onclick_location_filter()`.)  If we'd rather links open in a new window, let me know.
    10 - Uses a template part to output the inline CSS (see `/embeds/activity/css-activity.php`).  In order to auto-generate the RTL CSS, I'm piggybacking off of `grunt rtlcss` to generate the related RTL CSS template part.  As to why I'm opting for inline CSS, see comment:39.
     10- Uses a template part to output the inline CSS (see `/embeds/activity/css-activity.php`).  In order to auto-generate the RTL CSS, I'm piggybacking off of `grunt rtlcss` to generate the related RTL CSS template part.  As to why I'm opting for inline CSS, see comment:36.
    1111
    1212Here's a screenshot of a TED video in action: