Skip to:
Content

BuddyPress.org

Changes between Version 2 and Version 3 of Ticket #6772, comment 32


Ignore:
Timestamp:
05/13/2016 10:25:31 PM (8 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6772, comment 32

    v2 v3  
    33Check out `08.patch`.
    44
    5 The problem is WP adds a `'sandbox="allow-scripts"` attribute to the `<iframe>`.  In order for YouTube and Vimeo embeds to work (as well as Twitter, Soundcloud, Ted, DailyMotion, SlideShare and Kickstarter), we have to add the `allow-same-origin` value to the `<iframe>` `sandbox` attribute as well.  I'm only adding the `allow-same-origin` value if an activity item as an oEmbed item that matches the sites listed above.
     5The problem is WP adds a `'sandbox="allow-scripts"` attribute to the `<iframe>`.  In order for YouTube and Vimeo embeds to work (as well as Twitter, Soundcloud, Ted, DailyMotion, SlideShare and Kickstarter), we have to add the `allow-same-origin` value to the `<iframe>` `sandbox` attribute as well.  I'm only adding the `allow-same-origin` value if an activity item has an oEmbed item that matches the sites listed above.
    66
    77We could also fix this by removing the `sandbox` attribute altogether but I opted to leave it.