Changes between Initial Version and Version 1 of Ticket #6765, comment 6
- Timestamp:
- 04/20/2016 09:10:58 AM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #6765, comment 6
initial v1 1 1 Hi @hnla 2 2 3 I agree it's a good idea. But i don't think we need to use `bp_core_get_directory_pages()` again as the buddypress()->pagesglobal set by `bp_core_set_uri_globals()` is already using this function.3 I agree it's a good idea. But i don't think we need to use `bp_core_get_directory_pages()` again as the `buddypress()->pages` global set by `bp_core_set_uri_globals()` is already using this function. 4 4 5 5 So we could probably use a patch looking like 6765-02c.patch. But if i look at the components loaders code it seems more consistent to do 6765-02a.patch as that's the way we do it for directory slugs. 6 6 7 6765-02c.patch seems a bit "agressive" with plugins component to me. In the same spirirwe could also do 6765-02b.patch. Both are better for the user as he can set the title for any directory component and as a plugin developer i'd be ok with both.7 6765-02c.patch seems a bit "agressive" with plugins components to me. In the same spirit we could also do 6765-02b.patch. Both are better for the user as he can set the title for any directory component and as a plugin developer i'd be ok with both. 8 8 9 9 But if we only want to deal with our components and leave the choice to plugins authors, then 6765-02a.patch is best :)