Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #6765, comment 1


Ignore:
Timestamp:
01/18/2016 01:01:00 PM (4 years ago)
Author:
hnla
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6765, comment 1

    initial v1  
    55At this stage not tested is what occurs when we activate BP for the first time and create our initial BP dir WP Pages, but it reads to me as though there ought not to be problems here we'll create the pages before we have need to query for the page title string.
    66
    7 If this were simply included as is the consequence for existing sites would probably just be a change in the Activity component setup as this is the one component where we diverge from the page name we set in page creation and the name as set in setup_globals() 'Activity' Vs. 'Site-Wide Activity' display would change to 'Activity' unless the WP Page name had been changed. While not advocating we change sites display necessarily if we were to thinking through the process users would have to grapple with, at most, having to log into admin and update their page titles for the BP pages, developers that had gone to lengths to change BP's default beaviour with ? filters would likely not be affected, filtering on `bp_get_directory_title` would override the changes made here.
     7If this were simply included as is the consequence for existing sites would probably just be a change in the Activity component setup as this is the one component where we diverge from the page name we set in page creation and the name as set in setup_globals() 'Activity' Vs. 'Site-Wide Activity' display would change to 'Activity' unless the WP Page name had been changed. While not advocating we change sites display necessarily, if we were to and thinking through the process users would have to grapple with, at most, they would need to update their page titles for the BP pages, developers that had gone to lengths to change BP's default behaviour with ? filters would likely not be affected, filtering on `bp_get_directory_title` would override the changes made here.