Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#6748 closed defect (bug) (no action required)

extract() function is still used widely in BuddyPress

Reported by: slaFFik Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

I see here https://buddypress.trac.wordpress.org/search?q=extract%28&noquickjump=1&changeset=on&milestone=on&ticket=on a bunch of activity regarding removing extract() function from all over the code. But in some places (like BP_Groups_Widget class in widget() method) I still see this function.

Was it left on purpose?

Also, I see 49 other usages (not including legacy bbPress 1.x forums) in BuddyPress code.

Change History (3)

#1 @DJPaul
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

It is something we're moving away from when we make changes, but I don't think we are intending to refactor old code like this "just because".

Thanks for your attention about this; good spot. :)

#2 @boonebgorges
4 years ago

It is something we're moving away from when we make changes, but I don't think we are intending to refactor old code like this "just because".

One exception I'll make is this: if you're removing extract() use from a function that currently has insufficient unit test coverage, and your patch includes tests :) Otherwise, let's continue to remove extract() as we make other improvements to the functions in question.

#3 @DJPaul
3 years ago

  • Component changed from Tools - Code Improvement to Core
Note: See TracTickets for help on using tickets.