Opened 4 years ago
Last modified 3 years ago
#6745 closed defect (bug)
AJAX pagination doesn't account for new component search parameter — at Initial Version
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 2.4.2 | Priority: | normal |
| Severity: | normal | Version: | 2.4.0 |
| Component: | Core | Keywords: | has-patch |
| Cc: |
Description
When we changed the search parameter for BuddyPress directory pages (#5087), we did not account for pagination.
Attached patch fixes this.
Note: We currently do not add the search term parameter for the activity or blog template loops. We probably should do this either in 2.4.1 or 2.5.0.
This bug also uncovered an error with how we parse pagination page numbers in AJAX since WordPress 4.1. See #WP30831. The problem is due to r7946. (Basically, what henry.wright warned me about here - ticket:5404#comment:13! Boo Ray!)
The page number fix reverts what I committed in #5404 with what I originally recommended here:
https://buddypress.trac.wordpress.org/attachment/ticket/5404/5404.01.2.patch
I would preferably like to include this fix in 2.4.1 as well.