Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#6727 closed defect (bug) (fixed)

Update grunt-contrib-imagemin to v1.0.0

Reported by: netweb's profile netweb Owned by: djpaul's profile djpaul
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Cc:

Description

As mentioned in dev chat today weirdness issues surrounding grunt-contrib-imagemin were noted.

The root cause is due to dependancies included in grunt-contrib-imagemin

The issue only affects fresh SVN checkouts of BP or if you removed the node_modules folder of an existing checkout.

​https://github.com/gruntjs/grunt-contrib-imagemin/compare/v0.9.4...v1.0.0

Attachments (1)

6727.diff​ (486 bytes) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (7)

@netweb
10 years ago

This ticket was mentioned in ​Slack in #buddypress by netweb. ​View the logs.
10 years ago

#2 @imath
10 years ago

Thanks @netweb

I've just tested and i confirm it's fixing the issue.

#3 @DJPaul
10 years ago

  • Milestone changed from Awaiting Review to 2.5

#4 @djpaul
10 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10350:

Grunt: update grunt-contrib-imagemin from 0.9.4 to 1.0.0

Addresses failures seen in grunt release when we created the package for the 2.4 release.
Fixes #6727, props netweb

#5 @johnjamesjacoby
10 years ago

In 10397:

Grunt: update grunt-contrib-imagemin from 0.9.4 to 1.0.0 in the 2.4 branch.

Addresses failures seen in grunt release when we created the package for the 2.4 release.

Fixes #6727 even better than that other time. Props netweb.

#6 @DJPaul
9 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.