Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#6716 closed defect (bug) (no action required)

bp-screen-reader-text class and Themes overridding buddypress.css

Reported by: imath Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: dev-feedback
Cc: hnla

Description (last modified by imath)

Great improvements about accessibility has been committed into 2.4.0 and with them the use of the .bp-screen-reader-text class also increased.

Testing some themes (using BP Legacy and overriding the buddypress.css file) to check the cover images feature, i've noticed none of them were including this class inside their css file.

And i'm also a bad user, because my custom buddypress.css on the projects i'm working on wasn't including it :)

In 2.2 it was used 9 times, it's now used 44 times. So there is good chances some labels appear when they shouldn't... Just in case we'll have this patch ready..

Attachments (1)

6716.patch (1.8 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (9)

@imath
5 years ago

#1 @imath
5 years ago

  • Description modified (diff)

#2 @hnla
5 years ago

  • Cc hnla added

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 years ago

#4 @DJPaul
5 years ago

Is this needed?

#5 @hnla
4 years ago

I'm inclined to close this for following reasons:

First and foremost we are now past the danger point, if there had have been an issue we would have needed to deploy this by now!

As imath says he's a bad user :) and hasn't covered the class in his overloaded styles, this is a common class used to hide label text, we(BP) have added a number of these class tokens on labels that previously didn't exist & the ruleset however it has always to be the responsibility of the custom theme to deal with ensuring any new styles, script, or markup additions are accounted for.

Yes true those labels may appear, but enqueueing embedded head styles just to cover the possibility of a few custom themes having an issue? We're loading styles on every page, that won't cache just to prevent labels showing for a few themes do we want to do that? If we did perhaps we should load only if we detect overloaded theme?

#6 @DJPaul
4 years ago

  • Milestone changed from Under Consideration to Awaiting Review

#7 @DJPaul
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I agree. Hasn't proven to be a problem (yet?) in the Real World.

#8 @hnla
4 years ago

Ticket started 8 months ago, my comment 3 months ago, we haven't seen a problem brought to our attention so although a fair point to raise, we're well past any true problem point.

Note: See TracTickets for help on using tickets.