Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6715 closed defect (bug) (fixed)

undefined property: $stdclass::$theme

Reported by: danbp Owned by: imath
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc: danco38@…

Description

bp 2.4 rc1 (daily updated...)

When you deactivate BuddyPress, 2 notices show up briefly (a few seconds only):

undefined property: $stdclass::$theme

and trying to get property of a non-object

Origin: bp-core-theme-compatibility.php:178

Attachments (1)

6715.patch (549 bytes) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (5)

@imath
4 years ago

#1 @imath
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.4

Thanks for your feedback Dan.

i've quickly built the attached patch, will test it more soon. That's because we're checking the theme compat id inside the function that sets the cover image default settings for themes using the BP Theme Compat API

Last edited 4 years ago by imath (previous) (diff)

#2 @danbp
4 years ago

Thanks Mathieu, the patch seems to work.

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


4 years ago

#4 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10327:

Do not register default theme compat features on deactivation.

This prevents a notice error when deactivating BuddyPress.

Fixes #6715

Note: See TracTickets for help on using tickets.