Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

#6713 closed defect (bug) (fixed)

Overrides in bp_activity_set_mentions_scope_args() prevents searching into mentions

Reported by: imath Owned by: imath
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: Activity Keywords: dev-feedback commit
Cc:

Description

If you go to site.url/members/username/?activity_search=hello

The list will only display activities matching the search terms.

If you go to site.url/members/username/activity/mentions/?activity_search=hello

All mentions will be displayed.

That's because at the end of bp_activity_set_mentions_scope_args() we have this:

// Overrides.
		'override' => array(

			// Clear search terms so 'mentions' scope works with other scopes.
			'search_terms' => false,

I think it's too bad we can't perform an activity search inside mentions. I'm wondering why we reset the search_terms this way. Do we really need this ?

Change History (5)

#1 follow-up: @henry.wright
4 years ago

Isn't bp_activity_set_mentions_scope_args a filter for the site wide stream?

#2 in reply to: ↑ 1 @imath
4 years ago

Replying to henry.wright:

Isn't bp_activity_set_mentions_scope_args a filter for the site wide stream?

1) You have a mentions tab into the sitewide activities :)
2) It's used everywhere ;)

#3 @henry.wright
4 years ago

2) It's used everywhere ;)

Useful to know! Thanks :)

#4 @r-a-y
4 years ago

  • Keywords commit added

Sorry for the late reply here, imath.

To be honest, I cannot quite remember :)

I think it's because the older mentions search before activity scopes used a 'search_terms' parameter in bp_has_activities() and I was worried about some form of conflict.

Let's remove the line for 2.5. Thanks imath for looking into this!

#5 @imath
4 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10549:

Make sure an activity search can be performed on the "mentions" scope.

Fixes #6713

Note: See TracTickets for help on using tickets.