Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6697 closed enhancement (fixed)

RTL Banners for BuddyPress

Reported by: mercime Owned by: johnjamesjacoby
Priority: normal Milestone: 2.5
Component: BuddyPress.org Sites Version:
Severity: normal Keywords: has-patch has-screenshots
Cc:

Description

Per @netweb's reminder in ​Slack, plugin banners now have RTL support. Adding the links referenced in Slack just in case you-know-what.
Meta Trac: ​https://meta.trac.wordpress.org/ticket/757
RTL Site: ​https://he.wordpress.org/plugins/buddypress/

Attachments (3)

banner-1544x500-rtl.png​ (31.8 KB ) - added by mercime 11 years ago.
banner-772x250-rtl.png​ (22.9 KB ) - added by mercime 11 years ago.
bp-rtl.png​ (70.1 KB ) - added by mercime 11 years ago.

Download all attachments as: .zip

Change History (11)

#1 @mercime
11 years ago

  • Keywords has-patch has-screenshots added

banner-1544x500-rtl.png and banner-722x250-rtl.png attached for review.

@mercime
11 years ago

@mercime
11 years ago

#2 @DJPaul
11 years ago

  • Milestone Awaiting Review → Under Consideration

Have you been able to test these or did you just flip the image?

#3 @mercime
11 years ago

@DJPaul I flipped the hat but not the logo. Tested it only by saving the page of the rtl site to desktop and replacing the links to the images to the path where I saved the images in my laptop. Attaching screenshot of the test.

@mercime
11 years ago

This ticket was mentioned in ​Slack in #buddypress by mercime. ​View the logs.
11 years ago

#5 @DJPaul
11 years ago

  • Milestone Under Consideration → 2.5

Nice, let's do this. Thanks for showing the screenshot with it on a RTL site. :)

#6 @mercime
11 years ago

DJPaul Sure thing, no problem :)

#7 @DJPaul
11 years ago

  • Resolution → fixed
  • Status new → closed

Done in ​https://plugins.trac.wordpress.org/changeset/1309232/buddypress

Also minified the other image assets while I was in there.

Note: See TracTickets for help on using tickets.