#6697 closed enhancement (fixed)
RTL Banners for BuddyPress
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 2.5 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | BuddyPress.org Sites | Keywords: | has-patch has-screenshots |
| Cc: |
Description
Per @netweb's reminder in Slack, plugin banners now have RTL support. Adding the links referenced in Slack just in case you-know-what.
Meta Trac: https://meta.trac.wordpress.org/ticket/757
RTL Site: https://he.wordpress.org/plugins/buddypress/
Attachments (3)
Change History (11)
#2
@
9 years ago
- Milestone changed from Awaiting Review to Under Consideration
Have you been able to test these or did you just flip the image?
#3
@
9 years ago
@DJPaul I flipped the hat but not the logo. Tested it only by saving the page of the rtl site to desktop and replacing the links to the images to the path where I saved the images in my laptop. Attaching screenshot of the test.
This ticket was mentioned in Slack in #buddypress by mercime. View the logs.
9 years ago
#5
@
9 years ago
- Milestone changed from Under Consideration to 2.5
Nice, let's do this. Thanks for showing the screenshot with it on a RTL site. :)
#7
@
9 years ago
- Resolution set to fixed
- Status changed from new to closed
Done in https://plugins.trac.wordpress.org/changeset/1309232/buddypress
Also minified the other image assets while I was in there.
#8
@
9 years ago
Nice, in action here: https://he.wordpress.org/plugins/buddypress/
banner-1544x500-rtl.png and banner-722x250-rtl.png attached for review.