Opened 9 years ago
Closed 7 years ago
#6693 closed enhancement (maybelater)
Activity CPT tracking should handle deletion as well
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.2 |
Component: | Activity | Keywords: | needs-patch, dev-feedback, trac-tidy-2018 |
Cc: |
Description
The activity CPT tracking code does a good job with registering post types to handle creating activity items.
However, we do not handle deleting the corresponding activity when the post type item is deleted. We should automate this as well!
Change History (8)
#3
@
9 years ago
I had the same task in one of my plugins.
The hardest part is such (the decision):
We have wp_delete_post($post_id, $force = true)
- which is totally ok, its hook passes $post_id
and we can completely delete activity.
But there is also a wp_trash_post()
or wp_delete_post($post_id, $force = false)
- and we don't have a trash
for activity entries.
Personally I decided to ignore trash, so activity will still be there, and when trash will be emptied - only than activity will be deleted.
#7
@
7 years ago
- Keywords trac-tidy-2018 added
We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.
Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.
If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.
For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/
Good catch, I agree :)
I think we should also leave a chance to plugin developers to create activities when the post is private by adding an action for instance.