Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#6691 closed defect (bug) (wontfix)

do_action( 'bp_group_members_list_item_action' ) inside bp_is_active check

Reported by: modemlooper's profile modemlooper Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.7
Component: Templates Keywords: dev-feedback 2nd-opinion
Cc:

Description

If friends is inactive then any group member list class="action" hooks do not fire.

https://buddypress.trac.wordpress.org/browser/trunk/src/bp-templates/bp-legacy/buddypress/groups/single/members.php#L70

do_action( 'bp_group_members_list_item_action' ) should be outside the if()

Change History (8)

#1 @modemlooper
9 years ago

or better the friend button should be hooked to do_action( 'bp_group_members_list_item_action' ) and loaded if friends active :D

#2 @modemlooper
9 years ago

<div class="action">

	<?php if ( bp_is_active( 'friends' ) ) : ?>
		<?php bp_add_friend_button( bp_get_group_member_id(), bp_get_group_member_is_friend() ); ?>
	<?php endif; ?>

	<?php
	/**
	 * Fires inside the action section of an individual group member listing item.
	 *
	 * @since BuddyPress (1.1.0)
	 */
	do_action( 'bp_group_members_list_item_action' ); ?>

</div>

#3 @r-a-y
9 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from 2.4.1 to Awaiting Review
  • Version set to 1.7

Maybe use the 'bp_group_members_list_item' hook instead if the Friends component is not active?

#4 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to Under Consideration

#5 @DJPaul
8 years ago

  • Milestone changed from Under Consideration to Future Release

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @DJPaul
7 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#8 @DJPaul
7 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.