Skip to:

Opened 5 years ago

Closed 5 years ago

#6687 closed defect (bug) (fixed)

'Mentions' tab of the Activity directory & new_at_mention notifications

Reported by: imath Owned by: imath
Milestone: 2.5 Priority: normal
Severity: normal Version: 1.9
Component: Toolbar & Notifications Keywords: has-patch commit


Let's say someone mentioned you. And you are displaying the activity directory, The mentions tab is looking like this Mentions (1 new). If you click on it the bp_new_mention_count & bp_new_mentions usermetas are removed, but not the corresponding entries into the notifications table.

I think we should remove these notications.

Attachments (2)

6687.patch (2.0 KB) - added by imath 5 years ago.
6687.02.patch (3.6 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (6)

5 years ago

#1 @DJPaul
5 years ago

Yes. Bonus points if you can unit test this somehow.

#2 @imath
5 years ago

@DJPaul you're right, sorry i forgot the unit test about it. Working on this unit test made me change the patch to make it simpler as bp_activity_reset_my_new_mentions() is hooking to bp_activity_screen_mentions.

If no objections, i will commit 6687.02.patch this evening (6 or 7 hours from now).

5 years ago

#3 @imath
5 years ago

  • Keywords commit added

#4 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 10457:

Make sure notifications are marked as read when loading new mentions from the activity directory.

When a user has new mentions, the mentions tab of the activity directory displays the count of the new mantions available. When clicking on this tab, we need to make sure the corresponding notification entries are marked as read by the Notifications component.

Fixes #6687

Note: See TracTickets for help on using tickets.