Activity post form template improvements

[r-a-y]

Split from #6569.

Attached patch is a quick merge of both myself and imath's work from that ticket.

• Moves the "What's new, X" paragraph into the <textarea> as a placeholder.
• Adds a "Cancel" button.
• Various markup changes.
• autosize.js (There's some jumpiness in IE10-11).
• CSS arrow.

Here's what it kind of looks like:

(This is a previous GIF; not everything has been tested/ported.)

We'll use this ticket to make some decisions on the UI workflow.

Edit: Also see imath's comment for the other changes regarding buttons and UI - ticket:6569#comment:9.

[mercime]

Add back label tags

[mercime]

Hi @r-a-y Cool :) I hope this gets in somehow - new template pack/theme anyone? :)

6680.02.patch Adds back label tags to the textarea and select form controls. The placeholder attribute is not a replacement for the label tag which is needed for accessibility. Thanks.

[dcavins]

I'm uploading the results of testing this patch with the following themes: TwentyTwelve, TwentyThirteen, TwentySixteen, and two paid themes: Kleo and Boss. I also tested these changes with the plugin "BuddyPress Activity Plus" which was/is a popular way to add links and media to activity items.

I encountered problems with the Boss theme. (Boss uses a custom activity/post-form.php file.) The Boss theme is actively developed by good devs, so I have a good feeling about resolving those issues.

I don't think I'm seeing insurmountable backward compatibility issues here. Check out my cool GIFs and let me know what you're seeing.

I also would be happy to test other combinations, if you have one you want to see, or can think of a killer combo I missed.

[dcavins]

TwentyTwelve with no extras.

[dcavins]

TwentThirteen with no extras.

[dcavins]

TwentSixteen with no extras.

[dcavins]

Paid theme Kleo with no extras.

[dcavins]

TwentyTwelve with "Activity Plus" plugin.

[dcavins]

TwentyThirteen with "Activity Plus" plugin.

[dcavins]

TwentySixteen with "Activity Plus" plugin.

[dcavins]

Paid theme Kleo with "Activity Plus" plugin.

[dcavins]

Paid theme Boss against trunk.

[dcavins]

Paid theme Boss against with 6680.01.patch applied.

[boonebgorges]

We need more time to digest whether these breaks are acceptable, and whether there's a way to suss out the parts of the patch that don't break anything from the parts that do.

[DJPaul]

How about we fold this into BP-Nouveau instead?

[DJPaul]

Pinging for any last opinions, before this gets closed and the feature would be applicable for consideration to a future template pack.

[DJPaul]

I'm closing this, given lack of comments from contributors in the last 3 months about whether we want to make the change or not. Let's focus any effort on new features in BP-Legacy towards making BP-Nouveau a reality.