Skip to:
Content

Opened 3 years ago

Closed 19 months ago

#6680 closed enhancement (invalid)

Activity post form template improvements

Reported by: r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.2
Component: Templates Keywords: has-patch ux-feedback
Cc:

Description (last modified by r-a-y)

Split from #6569.

Attached patch is a quick merge of both myself and imath's work from that ticket.

  • Moves the "What's new, X" paragraph into the <textarea> as a placeholder.
  • Adds a "Cancel" button.
  • Various markup changes.
  • autosize.js (There's some jumpiness in IE10-11).
  • CSS arrow.

Here's what it kind of looks like:
http://imgreview.com/i/gVLuT

(This is a previous GIF; not everything has been tested/ported.)

We'll use this ticket to make some decisions on the UI workflow.

Edit: Also see imath's comment for the other changes regarding buttons and UI - ticket:6569#comment:9.

Attachments (12)

6680.01.patch (20.0 KB) - added by r-a-y 3 years ago.
6680.02.patch (5.4 KB) - added by mercime 2 years ago.
Add back label tags
2012-no-plugin.gif (279.3 KB) - added by dcavins 2 years ago.
TwentyTwelve with no extras.
2013-no-plugin.gif (345.4 KB) - added by dcavins 2 years ago.
TwentThirteen with no extras.
2016-no-plugin.gif (263.6 KB) - added by dcavins 2 years ago.
TwentSixteen with no extras.
kleo-no-plugin.gif (218.6 KB) - added by dcavins 2 years ago.
Paid theme Kleo with no extras.
2012-w-plugin.gif (383.0 KB) - added by dcavins 2 years ago.
TwentyTwelve with "Activity Plus" plugin.
2013-w-plugin.gif (388.6 KB) - added by dcavins 2 years ago.
TwentyThirteen with "Activity Plus" plugin.
2016-w-plugin.gif (467.2 KB) - added by dcavins 2 years ago.
TwentySixteen with "Activity Plus" plugin.
kleo-w-plugin.gif (248.8 KB) - added by dcavins 2 years ago.
Paid theme Kleo with "Activity Plus" plugin.
boss-pre-6680.gif (130.7 KB) - added by dcavins 2 years ago.
Paid theme Boss against trunk.
boss-w-6680-problem.gif (44.0 KB) - added by dcavins 2 years ago.
Paid theme Boss against with 6680.01.patch applied.

Change History (25)

@r-a-y
3 years ago

#1 @r-a-y
3 years ago

  • Description modified (diff)

#2 @r-a-y
2 years ago

  • Milestone changed from 2.5 to 2.6

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


2 years ago

@mercime
2 years ago

Add back label tags

#4 @mercime
2 years ago

Hi @r-a-y Cool :) I hope this gets in somehow - new template pack/theme anyone? :)

6680.02.patch Adds back label tags to the textarea and select form controls. The placeholder attribute is not a replacement for the label tag which is needed for accessibility. Thanks.

#5 @dcavins
2 years ago

I'm uploading the results of testing this patch with the following themes: TwentyTwelve, TwentyThirteen, TwentySixteen, and two paid themes: Kleo and Boss. I also tested these changes with the plugin "BuddyPress Activity Plus" which was/is a popular way to add links and media to activity items.

I encountered problems with the Boss theme. (Boss uses a custom activity/post-form.php file.) The Boss theme is actively developed by good devs, so I have a good feeling about resolving those issues.

I don't think I'm seeing insurmountable backward compatibility issues here. Check out my cool GIFs and let me know what you're seeing.

I also would be happy to test other combinations, if you have one you want to see, or can think of a killer combo I missed.

@dcavins
2 years ago

TwentyTwelve with no extras.

@dcavins
2 years ago

TwentThirteen with no extras.

@dcavins
2 years ago

TwentSixteen with no extras.

@dcavins
2 years ago

Paid theme Kleo with no extras.

@dcavins
2 years ago

TwentyTwelve with "Activity Plus" plugin.

@dcavins
2 years ago

TwentyThirteen with "Activity Plus" plugin.

@dcavins
2 years ago

TwentySixteen with "Activity Plus" plugin.

@dcavins
2 years ago

Paid theme Kleo with "Activity Plus" plugin.

@dcavins
2 years ago

Paid theme Boss against trunk.

@dcavins
2 years ago

Paid theme Boss against with 6680.01.patch applied.

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


2 years ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


2 years ago

#8 @boonebgorges
2 years ago

  • Milestone changed from 2.6 to Future Release

We need more time to digest whether these breaks are acceptable, and whether there's a way to suss out the parts of the patch that don't break anything from the parts that do.

#9 @DJPaul
2 years ago

  • Component changed from Appearance to Templates

#10 @DJPaul
22 months ago

  • Milestone changed from Future Release to Under Consideration

How about we fold this into BP-Nouveau instead?

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


22 months ago

#12 @DJPaul
20 months ago

Pinging for any last opinions, before this gets closed and the feature would be applicable for consideration to a future template pack.

#13 @DJPaul
19 months ago

  • Milestone Under Consideration deleted
  • Resolution set to invalid
  • Status changed from new to closed

I'm closing this, given lack of comments from contributors in the last 3 months about whether we want to make the change or not. Let's focus any effort on new features in BP-Legacy towards making BP-Nouveau a reality.

Note: See TracTickets for help on using tickets.