Changes between Initial Version and Version 1 of Ticket #6669, comment 5
- Timestamp:
- 10/18/2015 11:10:54 AM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #6669, comment 5
initial v1 5 5 https://plugins.trac.wordpress.org/browser/bbpress/tags/2.5.8/includes/extend/buddypress/notifications.php#L41 6 6 7 I think the {{{bbp_format_buddypress_notifications()}}} function will suffer from the same problems I came across because that doesn't return a value in cases where {{{'bbp_new_reply' !== $action}}} ?But looking at trunk, that function now seems to have been rewritten to return a value (like you suggested above).7 I think the {{{bbp_format_buddypress_notifications()}}} function will suffer from the same problems I came across because that doesn't return a value in cases where {{{'bbp_new_reply' !== $action}}}. But looking at trunk, that function now seems to have been rewritten to return a value (like you suggested above). 8 8 9 9 Also, thanks for the advice you gave in your {{{my_register_custom_notifications()}}} function above, that looks a neat way of doing it. Which approach of the two would you recommend?