Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#6660 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings

Reported by: ramiy Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description

In the next version of WordPress (4.4), we fixed many translation strings that used HTML tags, removing the HTML tags out from the strings.

See: https://core.trac.wordpress.org/query?milestone=4.4&component=I18N&reporter=ramiy&group=milestone&col=id&col=summary&col=milestone&col=type&col=priority&col=component&col=severity&col=resolution&order=priority

The same thing should be done in BuddyPress.

See the attached patches.

Attachments (11)

6660-em.patch (1.8 KB) - added by ramiy 5 years ago.
6660-code.patch (1.1 KB) - added by ramiy 5 years ago.
6660-strong.patch (1.6 KB) - added by ramiy 5 years ago.
6660-span.patch (11.6 KB) - added by ramiy 5 years ago.
6660-bp-activity-admin.php.patch (722 bytes) - added by ramiy 5 years ago.
6660-bp-activity-admin.php2.patch (754 bytes) - added by ramiy 5 years ago.
6660-p.patch (1.4 KB) - added by ramiy 5 years ago.
move the <p> tag out of the string
6660-core.patch (882 bytes) - added by ramiy 5 years ago.
split into two separate strings
6660-confirm-blog-signup.patch (887 bytes) - added by ramiy 5 years ago.
one more
6660-visibility-level.patch (936 bytes) - added by ramiy 5 years ago.
6660-visibility-level2.patch (3.8 KB) - added by ramiy 5 years ago.
like the patch above, but with more similar strings

Download all attachments as: .zip

Change History (28)

@ramiy
5 years ago

@ramiy
5 years ago

@ramiy
5 years ago

@ramiy
5 years ago

This ticket was mentioned in Slack in #buddypress by ramiy. View the logs.


5 years ago

#2 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10261:

Activity: avoid using HTML tags in translation strings.

Fixes #6660

Props ramiy

#3 @djpaul
5 years ago

In 10262:

Groups: avoid using HTML tags in translation strings.

Fixes #6660

Props ramiy

#4 @djpaul
5 years ago

In 10263:

Members: avoid using HTML tags in translation strings.

Fixes #6660

Props ramiy

#5 @djpaul
5 years ago

In 10264:

Settings: avoid using HTML tags in translation strings.

Fixes #6660

Props ramiy

#6 @djpaul
5 years ago

In 10265:

Templates: avoid using HTML tags in translation strings.

Fixes #6660

Props ramiy

#7 @boonebgorges
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for more sprintf goodness.

@ramiy
5 years ago

move the <p> tag out of the string

#8 @boonebgorges
5 years ago

In 10266:

Avoid using HTML in strings in bp-activity-admin.php.

Props ramiy.
See #6660.

@ramiy
5 years ago

split into two separate strings

@ramiy
5 years ago

one more

#9 @boonebgorges
5 years ago

In 10267:

More removal of markup from localizable strings.

Props ramiy.
See #6660.

@ramiy
5 years ago

like the patch above, but with more similar strings

#10 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.4

#11 @DJPaul
5 years ago

Not sure what the purpose of the change proposed in 6660-confirm-blog-signup.patch, so skipping that one.

#12 @djpaul
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 10272:

Templates: avoid using HTML tags in translation strings

Fixes #6660

Props ramie

#13 @djpaul
5 years ago

In 10273:

xprofile: avoid using HTML tags in translation strings.

Fixes #6660

Props ramie

#14 @DJPaul
5 years ago

Sorry - just seen I spelt your name wrong, ramiy. I am very sorry and will pay more attention for future commits.

#15 @ramiy
5 years ago

That's Ok.

Thanks for committing my patches.

This ticket was mentioned in Slack in #buddypress by ramiy. View the logs.


5 years ago

#17 @DJPaul
4 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.