Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #6642, comment 11


Ignore:
Timestamp:
10/07/2015 11:13:30 PM (9 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6642, comment 11

    v1 v2  
    1616changelog.json:
    1717
    18 - I do echo DJPaul's concerns about shipping a `changelog.json` file into core.  Couldn't we add it to the `/tags/xxx/` or `/branches/xxx/` repo and omit it from release?  When the `Templates` tab fetches the changelog, it fetches the JSON file from Trac instead?  If we are packaging the file, perhaps format it as a HTML file instead so it functions okay if someone is just looking at the file? (Yeah, I know this is more work... DO NOT SPEND TIME ON THIS! I'm just thinking out loud!)
     18- I do echo DJPaul's concerns about shipping a `changelog.json` file into core.  Couldn't we add it to the `/tags/xxx/` or `/branches/xxx/` repo and omit it from release?  When the `Templates` tab fetches the changelog, it fetches the JSON file from Trac instead?
     19  - If we are packaging the file, perhaps format it as a HTML file instead so it functions okay if someone is just looking at the file? (Yeah, I know this is more work... __Do not spend time on this! __ I'm just thinking out loud!)
    1920
    2021- I also love the automation about parsing our own internal commit logs for the changelog.json file.  DJPaul mentions that this is only in English; I do not think this is a big deal if we are only exposing this via `WP_DEBUG` (meaning only developers would be checking this out).  Localizing these commit messages would mean adding the changelog into core as a PHP file, which means more work for translators and also that this file could grow over time.  So I am kind of against localizing the changelog.