Duplicate at-who element IDs in Activity Streams

[mercime]

Multiple instances of the following ids show up in Sitewide, Group, and Member activity streams:

• <input type="hidden" id="_wpnonce_new_activity_comment" name="_wpnonce_new_activity_comment" value="135f85db1b">

and

• <div class="atwho-view" id="at-view-64">

[DJPaul]

at-view coming from the jquery.atwho.js library. Probably should get that up to date first, then look at this (looks like there's a parameter we can set)

[tw2113]

@mercime @DJPaul

Any reason not to update this library? We're presently at 0.5.2 and the latest release is 1.5.3

​https://github.com/ichord/At.js

Other than compat testing/confirmation.

[mercime]

@tw2113 Yes update both At.js and Caret.js. Per notice: "At.js depends on Caret.js."

[tw2113]

good catch. I did not notice that part.

[DJPaul]

Yes, both need updating. There might be some API change given the major part of that version has changed, so definitely check out the docs.

[djpaul]

In 11795:

Core, Activity: update at-mentions scripts to latest versions.

See #6640

[DJPaul]

Updated at-who scripts, those still appear in the markup. It's beyond my skill level with JS to understand why/what it's doing, so it'll remain until someone else looks at it (another couple of years, maybe! lol).

[DJPaul]

I can't see how to reproduce the _wpnonce_new_activity_comment duplication (maybe we fixed it), so I'm going to rename this ticket appropriately.

[dcavins]

I also ran into this issue with the atwho library creating a number of elements with the same ID. I'll attach a patch that solves the issue (by removing the ID assignment, because the IDs aren't used anyway).

Also note that I've created a ticket for that the nonce inputs with the duplicated IDs (I didn't see that this ticket existed). Please see the patch attached to that ticket: #8004

Thanks!

[dcavins]

Remove duplicate IDs from atwho elements.

[boonebgorges]

Related: #8001