Skip to:
Content

BuddyPress.org

Opened 4 years ago

Last modified 9 months ago

#6640 new defect (bug)

Duplicate at-who element IDs in Activity Streams

Reported by: mercime Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Activity Keywords:
Cc:

Description

Multiple instances of the following ids show up in Sitewide, Group, and Member activity streams:

  • <input type="hidden" id="_wpnonce_new_activity_comment" name="_wpnonce_new_activity_comment" value="135f85db1b">

and

  • <div class="atwho-view" id="at-view-64">

Attachments (1)

6640.01.diff (678 bytes) - added by dcavins 9 months ago.
Remove duplicate IDs from atwho elements.

Download all attachments as: .zip

Change History (14)

#1 @DJPaul
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release

#2 @DJPaul
3 years ago

at-view coming from the jquery.atwho.js library. Probably should get that up to date first, then look at this (looks like there's a parameter we can set)

#3 @DJPaul
3 years ago

  • Keywords has-patch removed

#4 @tw2113
2 years ago

@mercime @DJPaul

Any reason not to update this library? We're presently at 0.5.2 and the latest release is 1.5.3

https://github.com/ichord/At.js

Other than compat testing/confirmation.

#5 @mercime
2 years ago

@tw2113 Yes update both At.js and Caret.js. Per notice: "At.js depends on Caret.js."

#6 @tw2113
2 years ago

good catch. I did not notice that part.

#7 @DJPaul
2 years ago

  • Milestone changed from Future Release to 3.0

Yes, both need updating. There might be some API change given the major part of that version has changed, so definitely check out the docs.

#8 @djpaul
21 months ago

In 11795:

Core, Activity: update at-mentions scripts to latest versions.

See #6640

#9 @DJPaul
21 months ago

Updated at-who scripts, those still appear in the markup. It's beyond my skill level with JS to understand why/what it's doing, so it'll remain until someone else looks at it (another couple of years, maybe! lol).

#10 @DJPaul
21 months ago

I can't see how to reproduce the _wpnonce_new_activity_comment duplication (maybe we fixed it), so I'm going to rename this ticket appropriately.

#11 @DJPaul
21 months ago

  • Milestone changed from 3.0 to Future Release
  • Summary changed from Duplicate IDs in Activity Streams to Duplicate at-who element IDs in Activity Streams

#12 @dcavins
9 months ago

I also ran into this issue with the atwho library creating a number of elements with the same ID. I'll attach a patch that solves the issue (by removing the ID assignment, because the IDs aren't used anyway).

Also note that I've created a ticket for that the nonce inputs with the duplicated IDs (I didn't see that this ticket existed). Please see the patch attached to that ticket: #8004

Thanks!

@dcavins
9 months ago

Remove duplicate IDs from atwho elements.

Note: See TracTickets for help on using tickets.