Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6635 closed enhancement (fixed)

Remove calls to screen_icon().

Reported by: tw2113 Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Administration Keywords: good-first-bug has-patch
Cc:

Description

With #6258 well in the works and BuddyPress Core supporting only WordPress 3.8+ soon, we can remove usage of the screen_icon() function in admin pages.

Attachments (1)

patch.diff (7.0 KB) - added by JeffMatson 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @DJPaul
5 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Nice catch.

@JeffMatson
5 years ago

#2 @JeffMatson
5 years ago

All instances of screen_icon() removed in the above patch.

#3 @DJPaul
5 years ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 2.4

Hi @JeffMatson

Thank you for the patch, I'll look at getting it added later today. And, as far as I can tell, this is your first ever contribution to BuddyPress, so thank you *very* much for that! :)

#4 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10229:

Remove all calls to screen_icon

screen_icon was deprecated in WP 3.8 and has not done anything since
then. As BuddyPress 2.4 raises the minimum WP requirement to 3.9, we
can now remove these calls.

Fixes #6635

Props JeffMatson

#5 @DJPaul
5 years ago

I made an unfortunate typo in this commit: our minimum WP is 3.8.

Fortunately, this does not have any impact on this change.

Sorry for any confusion.

Note: See TracTickets for help on using tickets.