Accessibility: Form elements in bp-groups/

[mercime]

Bind labels to form controls: add 'id' attributes to form controls as needed, add 'for' attributes to labels, and improve markup as needed.

[mercime]

Groups Widget: Title - change the 'for' value of the label tag to match the 'id' value of the text input field.
bp-groups-widgets-title-id-for.patch

[mercime]

Groups Widget: Link Title - Add 'id' attribute for text input field and use the new 'id' value to replace the 'for' value of the label tag.
bp-groups-widgets-linktitle-id-for.php

[mercime]

Groups Widget: Select element - Replace the 'for' value of the label with the value of the newly created 'id' attribute of the select element.
bp-groups-widgets-select-id-for.php

[mercime]

Groups Widget: Max no. of groups- Replace the 'for' value of the label with the value of the 'id' attribute of the text field.
bp-groups-widgets-maxnum-id-for.php

[hnla]

@mercime what does the result of $this->get_field_id( 'max_groups' ) read like?

[mercime]

@hnla Thanks for checking this out.
"widget-bp_groups_widget-2-max_groups", "widget-bp_groups_widget-3-max_groups", etc.

[hnla]

@mercime was just concerned whether this pushed out a readable token, but realised it mattere little as we're having to match an existing ID already in use, but albeit slightly verbose it is readable.

These all look fine though I would go ahead and commit.

[mercime]

@hnla Thank you :)

[mercime]

In 10114:

Groups Widget: Replace the 'for' value with 'id' value of input field.

Accessibility fix which replaces the static 'for' value with the
dynamic 'id' value of the input field.

See #6623.

[mercime]

In 10115:

Groups Widget: Add 'id' attribute for checkbox field.

Accessibility fix to correct the value of the label 'for' attribute
and use the same dynamic value in the new 'id' attribute of the
checkbox field to link the widget title to the Groups directory page.

See #6623.

[mercime]

In 10116:

Groups Widget: Replace the 'for' value with 'id' value of input field.

Accessibility fix which replaces the static 'for' value with the
dynamic 'id' value of the input field.

See #6623.

[mercime]

In 10117:

Groups Widget: Add 'id' attribute to input field and bind to label.

Accessibility fix adds dynamic 'id' value which also replaces the old
'for' value in order to avoid duplicate 'ids' in DOM when more than
one Groups Widget is added to a theme's available widget areas. This
also unwraps the label tag from the select field.

See #6623.

[DJPaul]

@mercime is this ticket resolved?