#6618 closed enhancement (fixed)
Accessibility: Form elements in bp-templates/
Reported by: | mercime | Owned by: | mercime |
---|---|---|---|
Milestone: | 2.4 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Templates | Keywords: | |
Cc: |
Description
Bind labels to form inputs because some assistive technologies do not understand implicit relationships between labels and widgets.
Attachments (12)
Change History (48)
#4
@
9 years ago
Members: Bind label
to form control in user capabilities.
patch: 6618-member-register-for.2.2.patch
#7
@
9 years ago
- Severity changed from normal to minor
- Type changed from defect (bug) to enhancement
Best practise is always to make explicit associations really regardless of wrapping controls in labels. I would commit all of these. Good job!
#16
@
9 years ago
Settings > Delete Account: Add 'for' attribute to the label
for the checkbox input
field to delete own account.
bp-template-members-delete-account
#18
@
9 years ago
- Milestone changed from Awaiting Review to 2.4
Attached 6618-group-manage-settings-for-id-html.patch fixes Group Manage > Settings:
- unwrap
labels
fromuls
for valid markups - remove
<strong>
tags surrounding label texts - add 'id' attributes to
radio inputs
- add 'aria-describedby' attributes to
radio inputs
- add 'id' attributes to
ul
s to bind to 'aria-describedby' inradio inputs
- add 'for' attributes to
labels
Before and after screenshots for the following themes:
#19
@
9 years ago
Attached 6618-group-create-for-id.patch fixes Group Create Step 2:
- remove <strong> tags surrounding label texts
- add 'id' attributes to radio inputs
- add 'aria-describedby' attributes to radio inputs
- add 'id' attributes to uls to bind to 'aria-describedby' in radio inputs
- add 'for' attributes to labels
Before and after screenshots for the following themes:
#22
@
9 years ago
The second phase of improving accessibility for the Group Create Step 2 and Group Manage > Settings panels is to reconfigure the HTML markup by surrounding the radio elements within fieldsets and replace h4
headings with legends
. This change however, has some stylistic consequences which would require support in buddypress.css
and buddypress-rtc.css
.
#23
@
9 years ago
Think we may need to be careful here, starting to change markup is not only a stylistic matter but might well affect themes in ways hard to account for, this is why really I wanted to get a new set of template files underway where we had the freedom to strip back markup and re-build with no need to worry about existing sites.
#32
@
9 years ago
@hnla Thank you for your feedback. Sorry for the late reply. Perhaps we should discuss the second phase further in a new ticket to hold recommendations such as this? Or we can continue discussion here if you prefer re specific cases where change of markup to fieldset
(comment:22) plus backward-compatible styles could wreak havoc on layouts in existing sites.
#33
@
9 years ago
@mercime is there more to do here? If there's more to do but you need to discuss it a bit more, how about creating a new ticket for that for 2.5 so we can close this for 2.4?
Forums: Bind
labels
to form controls.