Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6617 closed defect (bug) (fixed)

Accessibility: Form elements in bp-core/

Reported by: mercime Owned by:
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Bind labels to form inputs because some assistive technologies do not understand implicit relationships between labels and widgets.

Attachments (2)

6617-bp-core-widgets-id.patch (1015 bytes) - added by mercime 5 years ago.
6617-bp-core-admin-tools.patch (877 bytes) - added by mercime 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @mercime
5 years ago

  • Component changed from API to Component - Core
  • Keywords has-patch added

Bind label to rememberme checkbox.

#2 @DJPaul
5 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.4

Fine to commit, but to learn, which assistive technologies don't like it?

#3 @hnla
5 years ago

As per the other tickets of this ilk, we should be always explicitly setting associations, it's always been best practise and we've dealt with a few but not on mass - good job @mercime.

@DjPaul: http://www.w3.org/WAI/WCAG20/Techniques/ua-notes/html#H44

#4 @mercime
5 years ago

@DJPaul Thank you as always. Good question. What @hnla linked to above, older versions of JAWS and Window-Eyes and considering the popularity of JAWS and how many computers are still on the older versions of JAWS and other ATs, using the for/id method is bulletproof - tried, tested, backward compatible, and HTML5 compatible - so it's very well recommended to use it where possible.

Thank you @hnla :)

#5 @mercime
5 years ago

In 10099:

Bind label to the Remember Me checkbox.

Accessibility fix for the BuddyPress Log In Widget.

See #6617.

#6 @mercime
5 years ago

Add 'for' attribute to labels in the BuddyPress Tools Panel in admin.
Attached: 6617-bp-core-admin-tools.patch

#7 @mercime
5 years ago

In 10165:

Add 'for' values to labels in BP Tools Settings screen.

See #6617.

#8 @DJPaul
5 years ago

@mercime is this ticket resolved?

#9 @DJPaul
5 years ago

  • Keywords has-patch commit removed

#10 @mercime
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.