bp_get_the_post_class() mistakenly removes classes

[dcavins]

bp_get_the_post_class() tries to unset the classes page and type-page on BuddyPress pages. However, it uses array_search() to find the key to unset and doesn't check for strict falsey-ness (array_search returns the found key--including 0-- or false if nothing is found).

In our function, if the targeted class isn't found, the zeroth element of the array is accidentally unset. I've added a strict check on the result of array_search() before unsetting anything.

This also could be done using array_diff(), if you have some idea that that would be more efficient/less klutzy, please let me know. :)

[dcavins]

Add strict check on result of array_search() in bp_get_the_post_class().

[DJPaul]

Nice spot

[r-a-y]

Fix looks good. You can blame me for this one!

I'm guessing that a plugin or theme might have removed the 'page' or 'type-page' CSS classes, which is why this is necessary.

[dcavins]

In 10109:

Limit class deletion in bp_get_the_post_class().

Prevent bp_get_the_post_class() from deleting
the zeroth element in the wp_classes array when
array_search() returns false.

Fixes #6615.

[dcavins]

Thanks @DJPaul and @r-a-y for your feedback!