Check box should have label in group invite page for making the consistency

[Ankit K Gupta]

On invitation of member in group creation page, Label is missing on check box text. It should have label same as other check box.

[Ankit K Gupta]

Screenshot of group creation page.

[Ankit K Gupta]

added patch file

[DJPaul]

Thanks for the report and the patch, @Ankit K Gupta! I think this is the first ticket you've reported to BuddyPress, so extra special thanks. :)

Next steps are that we need someone to review and test your patch. We'll do that as soon as possible, though of course anyone else can help. :)

[Ankit K Gupta]

Replying to DJPaul:

Thanks for the report and the patch, @Ankit K Gupta! I think this is the first ticket you've reported to BuddyPress, so extra special thanks. :)

Next steps are that we need someone to review and test your patch. We'll do that as soon as possible, though of course anyone else can help. :)

Hey DJPaul,
It's my pleasure!

Thanks for considering the issue :)

[hnla]

Replying to Ankit K Gupta:

Thanks Ankit it's a good spot, we've spent some time in this area and surprised we missed this.

You're right we should label these.

I ran the patch and modified slightly to add 'for' attr to the label even though it's an implicit association to the input.

There does appear to be an issue though with the WP 'checked()' function, it's echoing the checked function as a string we need to return it rather than echo it so really need to add the third optional param 'false' to counter the default setting 'true' checked($checked, 1, false) or the equivalent that works for BP's current implementation which is slightly quirky?

I'd update patch but haven't found a solution that works yet, also not sure why this hasn't come to light before, so could do with a second set of eyes on this!

[hnla]

Re-factor checked attr function to prevent echoing to screen. Add 'for' attr to label.

[hnla]

The checked() issue was introduced in #9939 trunk so patch 03 reverts out the checked() changes as they're not the concern of this ticket and original patch so leaving changes as introduction of labels and 'for' attr as per Ankit's patch and suggestion.

I'll open a separate ticket to handle fixing the checked issue.

[hnla]

Remove the checked function fix - label & 'for' attr addition only.

[mercime]

Thanks ankit-k-gupta :)

@hnla +1 for the 'for' attribute :) Attached is a 'before and after' screenshot which shows effect of adding label tag. Also attached is a patch which includes your changes plus style to counteract the enlarged font.

[mercime]

Thank you @DJPaul :)

[mercime]

In 10185:

Add label tags for checkboxes in Group invites screen.

Props ankit-k-gupta, hnla, mercime.
Fixes #6605.

[mercime]

In 10186:

Add style for new label in Group invites screen.

See #6605.

[Ankit K Gupta]

@all, Thanks for your efforts and adding my patch :)