Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6605 closed defect (bug) (fixed)

Check box should have label in group invite page for making the consistency

Reported by: Ankit K Gupta Owned by: mercime
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Groups Keywords: has-patch needs-testing commit
Cc: ankitgupta.sqa@…, ankit.himcs@…

Description

On invitation of member in group creation page, Label is missing on check box text. It should have label same as other check box.

Attachments (6)

Create_a_Group_NightwatchJS_Testing_-_2015-09-01_13.20.45.png (21.0 KB) - added by Ankit K Gupta 5 years ago.
Screenshot of group creation page.
6605.patch (995 bytes) - added by Ankit K Gupta 5 years ago.
added patch file
6605-02.patch (1.3 KB) - added by hnla 5 years ago.
Re-factor checked attr function to prevent echoing to screen. Add 'for' attr to label.
6605-03.patch (1.1 KB) - added by hnla 5 years ago.
Remove the checked function fix - label & 'for' attr addition only.
6605-new-labels.jpg (34.2 KB) - added by mercime 5 years ago.
6605.diff (2.2 KB) - added by mercime 5 years ago.

Download all attachments as: .zip

Change History (18)

@Ankit K Gupta
5 years ago

Screenshot of group creation page.

@Ankit K Gupta
5 years ago

added patch file

#1 @Ankit K Gupta
5 years ago

  • Cc ankit.himcs@… added

#2 follow-up: @DJPaul
5 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 2.4
  • Version 2.3.3 deleted

Thanks for the report and the patch, @Ankit K Gupta! I think this is the first ticket you've reported to BuddyPress, so extra special thanks. :)

Next steps are that we need someone to review and test your patch. We'll do that as soon as possible, though of course anyone else can help. :)

#3 in reply to: ↑ 2 ; follow-up: @Ankit K Gupta
5 years ago

Replying to DJPaul:

Thanks for the report and the patch, @Ankit K Gupta! I think this is the first ticket you've reported to BuddyPress, so extra special thanks. :)

Next steps are that we need someone to review and test your patch. We'll do that as soon as possible, though of course anyone else can help. :)

Hey DJPaul,
It's my pleasure!

Thanks for considering the issue :)

#4 in reply to: ↑ 3 @hnla
5 years ago

Replying to Ankit K Gupta:

Thanks Ankit it's a good spot, we've spent some time in this area and surprised we missed this.

You're right we should label these.

I ran the patch and modified slightly to add 'for' attr to the label even though it's an implicit association to the input.

There does appear to be an issue though with the WP 'checked()' function, it's echoing the checked function as a string we need to return it rather than echo it so really need to add the third optional param 'false' to counter the default setting 'true' checked($checked, 1, false) or the equivalent that works for BP's current implementation which is slightly quirky?

I'd update patch but haven't found a solution that works yet, also not sure why this hasn't come to light before, so could do with a second set of eyes on this!

Last edited 5 years ago by hnla (previous) (diff)

@hnla
5 years ago

Re-factor checked attr function to prevent echoing to screen. Add 'for' attr to label.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


5 years ago

#6 @hnla
5 years ago

The checked() issue was introduced in #9939 trunk so patch 03 reverts out the checked() changes as they're not the concern of this ticket and original patch so leaving changes as introduction of labels and 'for' attr as per Ankit's patch and suggestion.

I'll open a separate ticket to handle fixing the checked issue.

@hnla
5 years ago

Remove the checked function fix - label & 'for' attr addition only.

#7 @mercime
5 years ago

Thanks ankit-k-gupta :)

@hnla +1 for the 'for' attribute :) Attached is a 'before and after' screenshot which shows effect of adding label tag. Also attached is a patch which includes your changes plus style to counteract the enlarged font.

@mercime
5 years ago

#8 @DJPaul
5 years ago

  • Keywords commit added

#9 @mercime
5 years ago

Thank you @DJPaul :)

#10 @mercime
5 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10185:

Add label tags for checkboxes in Group invites screen.

Props ankit-k-gupta, hnla, mercime.
Fixes #6605.

#11 @mercime
5 years ago

In 10186:

Add style for new label in Group invites screen.

See #6605.

#12 @Ankit K Gupta
5 years ago

@all, Thanks for your efforts and adding my patch :)

Note: See TracTickets for help on using tickets.