Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 19 months ago

#6604 closed enhancement (maybelater)

BuddyPress Modal Iframe

Reported by: imath Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch, 2nd-opinion, trac-tidy-2018
Cc:

Description

While working on #6570, i've felt we'll surely need to have a BuddyPress modal (or a BuddyPress iframe). As the BuddyPress attachments scripts are loading only once per page load, it would help us for instance to be able to set the Avatar and the Cover image of a user or a group inside their corresponding Edit Administration screen.

Another option would be to have a massive javascript files to house code for the Avatar/The cover Image (and future attachment features), or some "require" js functionnalities.

This could also reply to a suggestion @dimensionmedia shared in slack about being able to set the cover image directly from any page of the user's profile thanks to a link into the new "fancy" header.

I think this new modal box could also be interesting to use for other needs in the future (eg: inserting some BuddyPress content into the WP Editor, into the Activity What's new form, opening an activity post form from any places of the site...).

So i've been working on a patch about this :

  • It extends (in a way the Thickbox feature) by adding a button to display the content of the window on the full available height, by including some functions to "dialog" with the opener, by making it more responsive (on front-end and in back-end) and better looking :)
  • It uses a specific template (assets/modal.php) with specific actions to print only the js and css we need.
  • I've included 2 examples of use : replace the way we edit a user profile photo within the Administration screen and add a new metabox to manage the group avatar in the corresponding Administration screen.

Here's a screenshot of the Group's Administration Screen :
https://cldup.com/34iNmZJlGg.png

I've set the milestone to 2.4 because i think if we want to be able to manage a cover image within Administration screens, we need it.

What do you think?

Attachments (1)

6604.patch (34.3 KB) - added by imath 4 years ago.

Download all attachments as: .zip

Change History (10)

@imath
4 years ago

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


4 years ago

#2 @imath
4 years ago

  • Milestone changed from 2.4 to Future Release

iframe has a bad reputation... Maybe it can change in the future :)

#3 @imath
4 years ago

Made a plugin out of this, in case you want to test it: https://github.com/imath/modal-buddy

#4 @DJPaul
3 years ago

  • Type changed from idea to enhancement

#5 @DJPaul
3 years ago

  • Component changed from API - Avatars to Media

#6 @DJPaul
3 years ago

  • Milestone changed from Future Release to Under Consideration

#7 @DJPaul
3 years ago

  • Milestone changed from Under Consideration to Future Release

#8 @DJPaul
19 months ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#9 @DJPaul
19 months ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.