#6582 closed defect (bug) (fixed)
WP 4.3 changed CSS breaks layout of Welcome Screen sections
Reported by: | mercime | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.3.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
WP 4.3 trunk, BP 2.4 trunk
Attached screenshot shows the broken layouts of “The Finer Points” and “Under the Hood” sections of BP's Welcome Screen Page as compared to https://buddypress.trac.wordpress.org/attachment/ticket/6433/welcome-screen.png.
There are different ways to address this issue, depending on whether the plan to redesign the Welcome Screen page for BP 2.4.0 will push through. One solution is add inline styles, another is to enqueue a stylesheet for this panel. Need decision for either way or to work on another option.
Attachments (3)
Change History (11)
#2
@
9 years ago
- Component changed from API to Component - Core
- Keywords has-patch added
Attached patch adds the minimum styles needed in common.css and common-rtl.css to bring the layout of the two sections back to former glory as seen in https://buddypress.trac.wordpress.org/attachment/ticket/6433/welcome-screen.png
This ticket was mentioned in Slack in #buddypress by mercime. View the logs.
9 years ago
#4
@
9 years ago
- Milestone changed from Awaiting Review to 2.3.3
If we add these to BP 2.3.3, they won't cause problems on older WP versions? Because it's the same markup? Right?
#5
@
9 years ago
@DJPaul Yes, it's the same markup and won't cause problems in at least WP 4.2 as I used core's style from that version in attached patch. Speaking of which, preparing another patch to include mobile-friendly style as well.
I'm not sure about the future plans for the Welcome Screen, but I think enqueueing a stylesheet seems better in this case.