Skip to:
Content

Opened 3 years ago

Closed 18 months ago

#6571 closed enhancement (fixed)

When email address is changed - send emails to old (with confirmation) and new email address

Reported by: wp_manyeung Owned by: johnjamesjacoby
Milestone: 2.5 Priority: normal
Severity: normal Version: 1.2
Component: Emails Keywords: dev-feedback
Cc:

Description

Hi,

I got a problem when I change my email.

I got the following message after changed my email:
=====
There is a pending change of your email address to new_email.
Check your email (old_email) for the verification link. Cancel
=====

And I received verification email which sent to new_email but not old_email.
Should the verification send to old_email?

I found the code in bp-settings-actions.php may be incorrect:

// Send the verification email
wp_mail( $user_email, sprintf( __( '[%s] Verify your new email address', 'buddypress' ), wp_specialchars_decode( bp_get_site_name() ) ), $content );

it should be

wp_mail( $old_user_email, sprintf( __( '[%s] Verify your new email address', 'buddypress' ), wp_specialchars_decode( bp_get_site_name() ) ), $content );

, right?

Change History (6)

#1 @johnjamesjacoby
3 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to Under Consideration
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned
  • Version changed from 2.3.1 to 1.2

Good question.

I think it's typical to send the verification link to the new email address (think of cases where the old address has been deleted and not forwarded) but we should probably attempt to send an email to the old address also, alerting it to the change.

What do you think?

#2 @wp_manyeung
3 years ago

Thanks @johnjamesjacoby

Yes, I think so

#3 @DJPaul
3 years ago

  • Milestone changed from Under Consideration to Future Release
  • Type changed from defect (bug) to enhancement

Sounds like a great idea.

#4 @slaFFik
19 months ago

  • Component changed from Settings to Emails
  • Keywords dev-feedback added; reporter-feedback removed
  • Summary changed from Verify new email address problem to When email address is changed - send emails to old (with cinformation) and new email address

Sending verification email to old address was fixed (perhaps) when @DJPaul worked on new emails.

Paul, will you be able to (and in general should we) add a new email, that will be sent to a new email address after its change via a click on confirmation link in an email sent to old email address?

#5 @slaFFik
19 months ago

  • Summary changed from When email address is changed - send emails to old (with cinformation) and new email address to When email address is changed - send emails to old (with confirmation) and new email address

#6 @DJPaul
18 months ago

  • Milestone changed from Future Release to 2.5
  • Resolution set to fixed
  • Status changed from assigned to closed

What happens right now is:

  • A BuddyPress email is sent to the old (still actually the current address). Nothing is sent to the new address.
  • After clicking the confirm link in that email, a WordPress email is sent to the old address, confirming the change. Nothing is sent to the current (the "new") address.

I can't remember if I changed this behaviour during the BP 2.5 email work or not. It seems likely, given the text of the original report.

We're actually ahead of WordPress here. It doesn't confirm the change of address if you change it via wp-admin (with BuddyPress disabled), I spoke to John Blackbourn about that earlier this year.

Paul, will you be able to (and in general should we) add a new email, that will be sent to a new email address after its change via a click on confirmation link in an email sent to old email address?

It seems a good idea, as the new email would form a counterpoint to the BuddyPress-styled email sent at the beginning of the process. However, that should go in a new ticket for someone to pick up in the future.

Note: See TracTickets for help on using tickets.