Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#6561 closed enhancement (fixed)

Minor class change for bp-core-admin-tools.php

Reported by: anthonyvalera's profile anthonyvalera Owned by: boonebgorges's profile boonebgorges
Milestone: 2.3.3 Priority: lowest
Severity: trivial Version: 2.3.2
Component: Core Keywords: ui-feedback
Cc:

Description

WP 4.2 changed the .tool-box class in tools.php to .card and cleaned the styles. Can we modify it to .card to match the new classes?

Added picture for reference

Attachments (1)

bp-tool-class.png​ (304.8 KB) - added by anthonyvalera 10 years ago.

Download all attachments as: .zip

Change History (6)

@anthonyvalera
10 years ago

#1 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 2.3.3

Good catch. Let's do this for the branch, since it's a WP compat fix.

#2 @boonebgorges
10 years ago

Small side note: removing the 'title' class from the h3 element brings it in line with WP 4.2+ styling, but makes it look slightly off in WP 4.1 and below. Let's update it for 4.2+ at the same time.

#3 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10024:

Available Tools selectors should match WP 4.2+.

Props anthonyvalera.
Fixes #6561.

#4 @boonebgorges
10 years ago

In 10025:

Available Tools selectors should match WP 4.2+.

Merges [10024] to the 2.3 branch.

Props anthonyvalera.
Fixes #6561.

#5 @DJPaul
9 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.