Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#6551 closed defect (bug) (fixed)

Wrong shape of the CROP size of the group thumbnail

Reported by: Diabolique Owned by:
Milestone: 2.3.3 Priority: normal
Severity: normal Version: 2.3.2
Component: Media Keywords:
Cc:

Description

When you change group thumbnail size then there is wrong shape of crop tool. I used following code in functions.php:

function group_thumbnail_size(){
	   define( 'BP_AVATAR_FULL_WIDTH', '200');
	   define( 'BP_AVATAR_FULL_HEIGHT', '100' );
	}
add_action('bp_init', 'group_thumbnail_size', 2);

And this what I see - http://www.imagebam.com/image/656252420037105
It's a real shame there is no way to change such basic thing like a groups thumbnail size.

Attachments (1)

crop.jpg (148.6 KB) - added by Diabolique 3 years ago.

Download all attachments as: .zip

Change History (11)

@Diabolique
3 years ago

#1 @r-a-y
3 years ago

  • Component changed from API to API - Avatars
  • Keywords needs-patch removed
  • Milestone set to 2.3.3
  • Priority changed from highest to normal

Looks like the fix was made in #6479 for v2.3.2, but during the build process, the avatar.min.js file was not updated.

To fix this temporarily, you can either do the following:

Add define( 'SCRIPT_DEBUG', true ); to wp-config.php.

This will load the unminified CSS and JS for everything in WordPress. This is a little heavy-handed.

Or:

You can copy /bp-core/js/avatar.js to /bp-core/js/avatar.min.js.

Last edited 3 years ago by r-a-y (previous) (diff)

#2 @imath
3 years ago

  • Keywords reporter-feedback added

thanks @r-a-y
i was surprised as i did fix this in 2.3.2

@Diabolique can you confirm doing one of the suggested temporary fix shared by r-a-y is fixing your issue ?

Last edited 3 years ago by imath (previous) (diff)

#3 @Diabolique
3 years ago

  • Keywords has-patch added

Yes, now it works. I copied avatar.js to avatar.min.js

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


3 years ago

#5 @DJPaul
3 years ago

The fix for this (the updated file) is now in the 2.3 branch, right? I think I remember it went in a few weeks ago.

#6 @imath
3 years ago

  • Keywords reporter-feedback has-patch removed

@DJPaul, absolutely it is already there in avatar.js since 2.3.2. But it looks like avatar.min.jshasn't been updated during the build process. So we just need to check it is the case in 2.3.3.

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


3 years ago

#8 @DJPaul
3 years ago

I don't know *how* 2.3.2(.1) was released, but when I run grunt build on the 2.3 branch, in build/bp-core/js/avatar.min.js:

this.options.aspectRatio=this.options.full_w/this.options.full_h

#9 @DJPaul
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#10 @DJPaul
2 years ago

  • Component changed from API - Avatars to Media
Note: See TracTickets for help on using tickets.