Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#6532 closed defect (bug) (fixed)

Accessibility BP admin screens: Add Labels and Remove Tab Index

Reported by: mercime Owned by: mercime
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Continuing with finding accessibility issues as noted in ticket #6531, I did a sweep of the BP Admin pages. Following are the issues found:

  • Activity (page=bp-activity) - label for select activity-type
  • Groups (page=bp-groups … action=edit) - for select and input elements
  • Profiles (page=bp-profile-edit) - for select elements
  • Profile Fields (page=bp-profile-setup) - for select, input, and textarea for all the different profile fields
  • Profile Set up (page=bp-profile-setup .. group_id .. field_id .. mode=edit_field) - for select, input, and textarea
  • Remove tab-index from Users > Profile Extended, input type="submit"
  • Remove tab-index from BP- Groups > Edit Group, input type="submit"
  • Remove tab-index from Activity > Edit, input type="submit"

Attachments (3)

6532-activity-select.patch (738 bytes) - added by mercime 3 years ago.
6532-group-select-input-textarea.patch (2.5 KB) - added by mercime 3 years ago.
6532-remove-tabindex.patch (1.9 KB) - added by mercime 3 years ago.

Download all attachments as: .zip

Change History (24)

#1 @mercime
3 years ago

  • Summary changed from Accessibility BP admin screens: Add Labels and Tab Index to Accessibility BP admin screens: Add Labels and Remove Tab Index

#2 @mercime
3 years ago

Attached patch adds label to Activity admin panel to filter activity-type

#3 @mercime
3 years ago

Attached patch adds labels to Group admin panel for the select, input, and text area form elements.

#4 @DJPaul
3 years ago

  • Keywords has-patch needs-testing good-first-bug added
  • Milestone changed from Awaiting Review to 2.4

#5 @mercime
3 years ago

In 10084:

Add label and 'id' in Activity admin screen.

Accessibility fix adds a label tag and 'id' attribute for the select
field in the Activity admin screen.

See #6532.

#6 @mercime
3 years ago

In 10090:

Add label tags for Group Admin form controls.

Accessibility fix adds label tags for two select fields, a textarea
field, and the wp_editor form control in the Groups admin screen when
editing a group in the backend.

See #6532.

#7 @mercime
3 years ago

Remove tabindex from submit buttons of Users > Profile Extended, Groups > Edit Group, and Activity > Edit screens. Attached: 6532-remove-tabindex.patch

#8 @mercime
3 years ago

In 10127:

Remove tabindex from BP Admin screens.

Accessibility fix removes tabindex from submit buttons of
Users > Profile Extended, Groups > Edit Group, and Activity > Edit
admin screens.

See #6532.

#9 @mercime
3 years ago

In 10175:

Add label for textarea of xProfile Field Description.

See #6532.

#10 @mercime
3 years ago

In 10176:

Add label for textarea of xProfile Group Description.

See #6532.

#11 @mercime
3 years ago

In 10187:

Add 'for' attribute to label tag for checkbox xProfile field.

See #6532.

#12 @mercime
3 years ago

In 10188:

Add 'for' attribute to label tag for radio xProfile fields.

See #6532.

#13 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10220:

Ensure specific classes are injected in BuddyPress widgets.

This fixes the styling of BuddyPress widgets in themes where the
developer has not used variables necessary to generate dynamic CSS
classes in their widget sidebar's before_widget call.

Props r-a-y, DJPaul.
Fixes #6532.

#14 @mercime
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The commit above (10220) was for ticket #5817, my bad.

Last edited 3 years ago by mercime (previous) (diff)

#15 @DJPaul
3 years ago

Is this ticket all resolved @mercime?

#16 @mercime
3 years ago

@DJPaul Not yet. Working on the xprofile fields. Thanks.

#17 @DJPaul
3 years ago

  • Keywords has-patch removed

#18 @mercime
3 years ago

  • Keywords needs-testing good-first-bug removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving the rest accessibility issues for xProfile fields to new ticket #6655 and closing this ticket.

#19 @mercime
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Correct screen reader class used in admin area and sneak in escaping translations in the sections committed.

#20 @mercime
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 10281:

Fix screen reader class of labels for textareas.

Fixes #6532.

#21 @DJPaul
2 years ago

  • Component changed from API to Core
Note: See TracTickets for help on using tickets.