Accessibility BP admin screens: Add Labels and Remove Tab Index

[mercime]

Continuing with finding accessibility issues as noted in ticket #6531, I did a sweep of the BP Admin pages. Following are the issues found:

• Activity (page=bp-activity) - label for select activity-type
• Groups (page=bp-groups … action=edit) - for select and input elements
• Profiles (page=bp-profile-edit) - for select elements
• Profile Fields (page=bp-profile-setup) - for select, input, and textarea for all the different profile fields
• Profile Set up (page=bp-profile-setup .. group_id .. field_id .. mode=edit_field) - for select, input, and textarea
• Remove tab-index from Users > Profile Extended, input type="submit"
• Remove tab-index from BP- Groups > Edit Group, input type="submit"
• Remove tab-index from Activity > Edit, input type="submit"

[mercime]

Attached patch adds label to Activity admin panel to filter activity-type

[mercime]

Attached patch adds labels to Group admin panel for the select, input, and text area form elements.

[mercime]

In 10084:

Add label and 'id' in Activity admin screen.

Accessibility fix adds a label tag and 'id' attribute for the select
field in the Activity admin screen.

See #6532.

[mercime]

In 10090:

Add label tags for Group Admin form controls.

Accessibility fix adds label tags for two select fields, a textarea
field, and the wp_editor form control in the Groups admin screen when
editing a group in the backend.

See #6532.

[mercime]

Remove tabindex from submit buttons of Users > Profile Extended, Groups > Edit Group, and Activity > Edit screens. Attached: 6532-remove-tabindex.patch

[mercime]

In 10127:

Remove tabindex from BP Admin screens.

Accessibility fix removes tabindex from submit buttons of
Users > Profile Extended, Groups > Edit Group, and Activity > Edit
admin screens.

See #6532.

[mercime]

In 10175:

Add label for textarea of xProfile Field Description.

See #6532.

[mercime]

In 10176:

Add label for textarea of xProfile Group Description.

See #6532.

[mercime]

In 10187:

Add 'for' attribute to label tag for checkbox xProfile field.

See #6532.

[mercime]

In 10188:

Add 'for' attribute to label tag for radio xProfile fields.

See #6532.

[mercime]

In 10220:

Ensure specific classes are injected in BuddyPress widgets.

This fixes the styling of BuddyPress widgets in themes where the
developer has not used variables necessary to generate dynamic CSS
classes in their widget sidebar's before_widget call.

Props r-a-y, DJPaul.
Fixes #6532.

[mercime]

The commit above (10220) was for ticket #5817, my bad.

[DJPaul]

Is this ticket all resolved @mercime?

[mercime]

@DJPaul Not yet. Working on the xprofile fields. Thanks.

[mercime]

Moving the rest accessibility issues for xProfile fields to new ticket #6655 and closing this ticket.

[mercime]

Correct screen reader class used in admin area and sneak in escaping translations in the sections committed.

[mercime]

In 10281:

Fix screen reader class of labels for textareas.

Fixes #6532.