Support emojis

[r-a-y]

WP 4.2 added support for emojis.

However, there is a bug report on the forums saying that adding emojis to an activity update causes an error when posting:
​https://buddypress.org/support/topic/wp-does-emoji-bp-does-not/

I haven't looked into this report yet, so I'm leaving this in the "Awaiting Review" milestone for now.

[DJPaul]

Don't really think it's a bug, it's not supported yet in BP: #6346

[r-a-y]

Sorry, didn't mean to mark this ticket as a bug!

After looking into the emoji spec, we should get this for free after #6346 is addressed.

Marking as a duplicate.

[r-a-y]

So I came across a WP function that converts emojis over to HTML encoding.

We should be able to easily support emojis with this:

add_filter( 'bp_activity_content_before_save', 'wp_encode_emoji' );

wp_encode_emoji() only supports Unicode 7 emojis though, but that's better than nothing! The function is only supported in WP 4.2+, so if we add this to the codebase, we'd have to do a conditional on the WP version.

For now, I'm adding this back to the 2.5 milestone for some feedback.

[r-a-y]

I think this one is an easy win!

Tested with WP 4.4 and a copy-and-pasted emoji, as well as with WP 3.8 to ensure no notices appear.

[imath]

Nice !

[DJPaul]

So... I thought we needed to migrate the tables to utf8mb4. What does that not do if we need to do this for emojis?

[r-a-y]

So... I thought we needed to migrate the tables to utf8mb4. What does that not do if we need to do this for emojis?

See comment:3.

According to the Docblock, wp_encode_emoji() only supports Unicode-7 emojis. The good news is there are only 37 Unicode-8 emojis:
​http://emojipedia.org/unicode-8.0/

However, I did a test of a few Unicode-8 emojis and wp_encode_emoji() worked for these as well.

I assume the DB upgrade would support all other emojis from Unicode-8.

[r-a-y]

Patch refreshed and now also supports private messages and group descriptions.

I didn't add xprofile support because it could affect display names, so I left that alone.

[r-a-y]

Switches out WP version check for function check.

[imath]

How come using 3 emojis fails in WP 3.9 ?

[r-a-y]

In 10572:

Support emojis for those using WordPress 4.2+.

WordPress introduced a function in WP 4.2 to encode emojis,
wp_encode_emoji().

We're using this function to encode emojis in activity streams, private
messages and group descriptions.

🍕

Fixes #6529.