Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#6514 closed enhancement (wontfix)

Trigger event when filter replaces content

Reported by: CodeMonkeyBanana Owned by:
Milestone: Priority: low
Severity: normal Version:
Component: Templates Keywords:
Cc: mikeymike81@…

Description

I am using isotope.js for organising members. I added this event so I could trigger isotope code without modifying core. Figured it might be helpful if buddypress triggered some events when it replaces content so you can write javascript that interacts with it without overriding buddypress core js file.

Attachments (2)

buddypress.js.patch (338 bytes) - added by CodeMonkeyBanana 5 years ago.
custom event trigger
buddypress.js.2.patch (815 bytes) - added by CodeMonkeyBanana 5 years ago.
Uses promise otherwise fires too early

Download all attachments as: .zip

Change History (9)

@CodeMonkeyBanana
5 years ago

custom event trigger

@CodeMonkeyBanana
5 years ago

Uses promise otherwise fires too early

#1 @CodeMonkeyBanana
5 years ago

  • Cc mikeymike81@… added

Ignore first file, that one fires too early.

#2 @DJPaul
5 years ago

  • Component changed from Component - Any/All to Appearance - Template Pack
  • Milestone changed from Awaiting Review to Future Release

This sort of thing is one of the many enhancements that we want to do to that JS file. We have been talking about improving/updating that file for a while now, and I'd probably suggest we wait for that so we don't give ourselves any future compatibility concerns (i.e. we add some now, but we rewrite it all later, and remove some then unnecessary custom events (which people might have started to rely on)).

Conversly, if we did move ahead with something like this in the short term, I'd want to see these added throughout the entire file where appropriate, not just on a couple of lines.

#3 @boonebgorges
5 years ago

Conversly, if we did move ahead with something like this in the short term, I'd want to see these added throughout the entire file where appropriate, not just on a couple of lines.

This seems like the right way forward in the short run. Let's try to get these in place wherever BP returns content via AJAX, and let's come up with a good naming convention for distinguishing between them. Passing 'object' and 'filter' won't be specific enough (or even applicable) in all cases.

#4 @DJPaul
5 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#5 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates

#6 @DJPaul
3 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#7 @DJPaul
3 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.