#6508 closed defect (bug)
jq('.item-list-tabs li.selected') isn't always defined on directories
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 2.3.1 |
Component: | Templates | Keywords: | has-patch dev-feedback |
Cc: | david.cavins@… |
Description
I noticed that searching on member and group directories was returning the error:
TypeError: jq(...).attr(...) is undefined -> css_id = jq('.item-list-tabs li.selected').attr('id').split( '-' ); -> buddypr...r=2.3.0 (line 818, col 12)
The cause is that often no tab is selected. My proposed fix falls back on the first tab if no tab is selected.
Attachments (1)
Change History (10)
#3
@
10 years ago
r-a-y is right i think one of the reason is in 6143
@DJPaul +1 and ideally loaded in the footer :)
#6
@
10 years ago
- Keywords dev-feedback added
Do we want to go ahead with this interim fix or not bother?
Note: See
TracTickets for help on using
tickets.
Can't wait until we rewrite this JS. :)
This looks OK to me unless someone wants to dive into the theme and figure out why the first tab isn't selected by default (don't we always show the contents of the first tab, which would make that not being selected the real bug, and not this?).